mirror of
https://github.com/eworm-de/routeros-scripts
synced 2024-05-14 08:04:19 +00:00
870f00bb36
___ _ ___ __
/ _ )(_)__ _ / _/__ _/ /_
/ _ / / _ `/ / _/ _ `/ __/
/____/_/\_, / /_/ \_,_/\__/
_ __ /___/ _ __
| | / /___ __________ (_)___ ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / / / / / / / / / / /_/ /_/
|__/|__/\__,_/_/ /_/ /_/_/_/ /_/\__, (_)
/____/
RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:
[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
That looks ok. Now we use a script:
{ :local interface "en1";
/ interface print where name=$interface; }
And the result...
[admin@MikroTik] > { :local interface "en1";
{... / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
... still looks ok.
We make a little modification to the script:
{ :local name "en1";
/ interface print where name=$name; }
And the result:
[admin@MikroTik] > { :local name "en1";
{... / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
1 S en2 ether 1500 1598
2 S en3 ether 1500 1598
3 S en4 ether 1500 1598
4 S en5 ether 1500 1598
5 R br-local bridge 1500 1598
Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).
And another modification:
{ :local type "en1";
/ interface print where name=$type; }
And the result:
[admin@MikroTik] > { :local type "en1";
{... / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.
The answer from MikroTik support (in Ticket#2019010222000454):
> This is how scripting works in RouterOS and we will not fix it.
To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...
*fingers crossed*
29 lines
1.4 KiB
Text
29 lines
1.4 KiB
Text
#!rsc
|
|
# RouterOS script: unattended-lte-firmware-upgrade
|
|
# Copyright (c) 2018-2019 Christian Hesse <mail@eworm.de>
|
|
#
|
|
# schedule unattended lte firmware upgrade
|
|
|
|
:foreach Interface in=[ / interface lte find ] do={
|
|
:local Firmware;
|
|
:local IntName [ / interface lte get $Interface name ];
|
|
do {
|
|
:set Firmware [ / interface lte firmware-upgrade $Interface once as-value ];
|
|
# strip the extra line break (TODO: remove when fixed upstream)
|
|
:set ($Firmware->"latest") [ :pick ($Firmware->"latest") 0 [ :find ($Firmware->"latest") "\n" ] ];
|
|
} on-error={
|
|
:log debug ("Could not get latest LTE firmware version for interface " . $IntName . ".");
|
|
}
|
|
|
|
:if (($Firmware->"installed") != ($Firmware->"latest")) do={
|
|
:log info ("Scheduling LTE firmware upgrade for interface " . $IntName . ".");
|
|
/ system script add name=($IntName . "-firmware-upgrade") source=("# unattended-lte-firmware-upgrade\n" . \
|
|
"/ system scheduler remove " . $IntName . "-firmware-upgrade;\n" . \
|
|
"/ system script remove " . $IntName . "-firmware-upgrade;\n" . \
|
|
"/ interface lte firmware-upgrade " . $IntName . " upgrade=yes;\n" . \
|
|
":log info (\"LTE firmware upgrade finished, waiting for installation before reset.\");\n" . \
|
|
":delay 150s;\n" . \
|
|
"/ interface lte at-chat " . $IntName . " input=\"AT+RESET\";");
|
|
/ system scheduler add name=($IntName . "-firmware-upgrade") on-event=($IntName . "-firmware-upgrade") interval=1m;
|
|
}
|
|
}
|