Commit graph

24 commits

Author SHA1 Message Date
Christian Hesse
f52a69cd97 check-routeros-update: link to changelog in notification 2019-03-29 12:23:16 +01:00
Christian Hesse
fee0b6eb9b check-routeros-update: default in capital letter
Also use square brackets as RouterOS does.
2019-02-22 21:41:49 +01:00
Christian Hesse
4c28e9f9c2 check-routeros-update: allow interactive update from terminal 2019-02-21 18:08:29 +01:00
Christian Hesse
5f7c727457 check-routeros-update: give board name and model 2019-02-19 22:56:28 +01:00
Christian Hesse
5f210eb1ec check-routeros-update: use new script 'packages-update' 2019-02-19 16:47:41 +01:00
Christian Hesse
c92ff8f9a6 check-routeros-update: run installation without-paging 2019-02-19 16:27:21 +01:00
Christian Hesse
eda4d10c0a check-routeros-update: run email-backup on auto-update 2019-01-18 11:08:11 +01:00
Christian Hesse
870f00bb36 global: variable names are CamelCase
___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*
2019-01-04 12:35:34 +01:00
Christian Hesse
688c757df0 check-routeros-update: be more verbose on error 2019-01-02 15:02:42 +01:00
Christian Hesse
a19f15c515 check-routeros-update: do not fail if safe-update-url return error
We still want the notification...
2019-01-02 15:02:42 +01:00
Christian Hesse
472cd3d905 update copyright for 2019 2019-01-02 09:38:34 +01:00
Christian Hesse
6e4d715937 global-functions: add identity tag in $SendNotification
... and send subject in telegram message.
2018-11-28 21:19:39 +01:00
Christian Hesse
e486332d36 check-routeros-update: use 'print count-only' 2018-11-09 21:37:19 +01:00
Christian Hesse
1bbbe3a5a7 global: remove unused variables 2018-10-10 21:49:46 +02:00
Christian Hesse
ba076db93e check-routeros-update: send notification on auto-update 2018-10-10 12:49:03 +02:00
Christian Hesse
e6c217aa0c check-routeros-update: use function for notification 2018-10-09 15:57:53 +02:00
Christian Hesse
be673737d3 start scripts with a magic token / shebang 2018-09-27 00:18:43 +02:00
Christian Hesse
2b09b1974a check-routeros-update: add missing space, break line 2018-09-20 20:33:19 +02:00
Christian Hesse
ddfa6d9053 check-routeros-update: send versions to safe-update-url 2018-09-19 22:18:42 +02:00
Christian Hesse
2de26a6617 check-routeros-update: enable auto update for safe version 2018-09-05 23:45:35 +02:00
Christian Hesse
23b167e84b check-routeros-update: resend notification if version changes 2018-08-30 11:14:01 +02:00
Christian Hesse
07e54dd88b add empty comment at first line...
... for better formatting in export.
2018-08-24 16:58:30 +02:00
Christian Hesse
a7fb431acd check-routeros-update: make the checks fool-proof 2018-07-09 20:41:31 +02:00
Christian Hesse
e1f134ead5 add scripts 2018-07-05 15:34:08 +02:00