Commit graph

42 commits

Author SHA1 Message Date
Christian Hesse c1dcc28028 add doc/check-routeros-update.md 2020-03-27 22:12:49 +01:00
Christian Hesse 0229516bb5 check-routeros-update: add fancy unicode symbol 2020-03-24 12:35:40 +01:00
Christian Hesse 970641a974 check-routeros-update: use $LogPrintExit 2020-03-05 09:08:57 +01:00
Christian Hesse 001e7eeb39 global-functions: sort alphabetically 2020-02-28 15:26:26 +01:00
Christian Hesse ceaa83b83e global-functions: merge $LogAnd{Error,Put} to $LogPrintExit ...
... and fix logging.

Logging with severity from variable (:log $severity ...) is not
possible, this is considered a syntax error. Also the 'workaround' with
parsing code failed with missing message in log.

The reliable code is a lot longer, so merge the two functions to save a
lot of duplicate code.
2020-02-26 14:19:54 +01:00
Christian Hesse 3ebf68a08c global-functions: $LogAndError: add severity 2020-02-26 12:09:19 +01:00
Christian Hesse 1d93bcbc0d check-routeros-update: use $LogAndError 2020-02-26 11:51:49 +01:00
Christian Hesse 12da4de305 check-routeros-update: do not act if reboot is scheduled 2020-01-16 16:11:50 +01:00
Christian Hesse afb9839073 update copyright for 2020 2020-01-01 17:00:39 +01:00
Christian Hesse f26222d5a8 check-routeros-update: use $ScriptFromTerminal 2019-12-03 23:45:55 +01:00
Christian Hesse 94581741f4 global-functions: introduce and use $DeviceInfo 2019-09-12 21:29:41 +02:00
Christian Hesse 5a3076c7c3 check-routeros-update: make notifications silent 2019-08-18 21:30:59 +02:00
Christian Hesse 4210a49098 check-routeros-update: fail on empty version string 2019-08-08 20:27:11 +02:00
Christian Hesse 21996dfcaf check-routeros-update: get values into array 2019-07-24 11:10:47 +02:00
Christian Hesse 9e3ee77a4a check-routeros-update: get values into array 2019-07-24 11:01:45 +02:00
Christian Hesse 08ef63ddbd check-routeros-update: link a changelog that opens in browser
The old link was delivered with MIME type 'application/octet-stream',
browsers wanted to download it as file.
2019-07-01 09:44:50 +02:00
Christian Hesse 0c45102798 check-routeros-update: drop literal 'notification' 2019-05-23 12:19:01 +02:00
Christian Hesse b35c0b8a6f always write warnings and errors to log 2019-04-03 21:30:43 +02:00
Christian Hesse f52a69cd97 check-routeros-update: link to changelog in notification 2019-03-29 12:23:16 +01:00
Christian Hesse fee0b6eb9b check-routeros-update: default in capital letter
Also use square brackets as RouterOS does.
2019-02-22 21:41:49 +01:00
Christian Hesse 4c28e9f9c2 check-routeros-update: allow interactive update from terminal 2019-02-21 18:08:29 +01:00
Christian Hesse 5f7c727457 check-routeros-update: give board name and model 2019-02-19 22:56:28 +01:00
Christian Hesse 5f210eb1ec check-routeros-update: use new script 'packages-update' 2019-02-19 16:47:41 +01:00
Christian Hesse c92ff8f9a6 check-routeros-update: run installation without-paging 2019-02-19 16:27:21 +01:00
Christian Hesse eda4d10c0a check-routeros-update: run email-backup on auto-update 2019-01-18 11:08:11 +01:00
Christian Hesse 870f00bb36 global: variable names are CamelCase
___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*
2019-01-04 12:35:34 +01:00
Christian Hesse 688c757df0 check-routeros-update: be more verbose on error 2019-01-02 15:02:42 +01:00
Christian Hesse a19f15c515 check-routeros-update: do not fail if safe-update-url return error
We still want the notification...
2019-01-02 15:02:42 +01:00
Christian Hesse 472cd3d905 update copyright for 2019 2019-01-02 09:38:34 +01:00
Christian Hesse 6e4d715937 global-functions: add identity tag in $SendNotification
... and send subject in telegram message.
2018-11-28 21:19:39 +01:00
Christian Hesse e486332d36 check-routeros-update: use 'print count-only' 2018-11-09 21:37:19 +01:00
Christian Hesse 1bbbe3a5a7 global: remove unused variables 2018-10-10 21:49:46 +02:00
Christian Hesse ba076db93e check-routeros-update: send notification on auto-update 2018-10-10 12:49:03 +02:00
Christian Hesse e6c217aa0c check-routeros-update: use function for notification 2018-10-09 15:57:53 +02:00
Christian Hesse be673737d3 start scripts with a magic token / shebang 2018-09-27 00:18:43 +02:00
Christian Hesse 2b09b1974a check-routeros-update: add missing space, break line 2018-09-20 20:33:19 +02:00
Christian Hesse ddfa6d9053 check-routeros-update: send versions to safe-update-url 2018-09-19 22:18:42 +02:00
Christian Hesse 2de26a6617 check-routeros-update: enable auto update for safe version 2018-09-05 23:45:35 +02:00
Christian Hesse 23b167e84b check-routeros-update: resend notification if version changes 2018-08-30 11:14:01 +02:00
Christian Hesse 07e54dd88b add empty comment at first line...
... for better formatting in export.
2018-08-24 16:58:30 +02:00
Christian Hesse a7fb431acd check-routeros-update: make the checks fool-proof 2018-07-09 20:41:31 +02:00
Christian Hesse e1f134ead5 add scripts 2018-07-05 15:34:08 +02:00