Commit graph

44 commits

Author SHA1 Message Date
Christian Hesse
6fa1525700 sms-forward: update initialization of empty array
Having the parenthesis here is important for valid syntax!
2022-07-13 11:35:46 +02:00
Christian Hesse
fbc6852687 sms-forward: RouterOS v7 path syntax 2022-05-11 13:48:27 +02:00
Christian Hesse
95e9820718 update copyright for 2022 2022-01-01 21:38:15 +01:00
Christian Hesse
0d249d6da4 sms-forward: pass origin to $SendNotification2 2021-04-28 13:58:37 +02:00
Christian Hesse
123fe01115 sms-forward: use $SendNotification2 2021-04-28 13:58:37 +02:00
Christian Hesse
041ca062b1 global: use $0 for $ScriptLock 2021-02-24 21:51:56 +01:00
Christian Hesse
f46db91845 global: give script or function name in log messages 2021-02-24 21:51:54 +01:00
Christian Hesse
d5afc79eed global: drop script 'global-wait'
All scripts wait for the global functions on their own now.
2021-02-18 21:45:38 +01:00
Christian Hesse
efca1ec049 global-functions: drop $MailServerIsUp
Now that we have an e-mail queue we do not care if the server is up or not.
2021-02-16 16:45:13 +01:00
Christian Hesse
547fbc630a update copyright for 2021 2021-01-01 21:33:52 +01:00
Christian Hesse
4af1f5dec2 sms-forward: improve wording for single/multiple message(s) 2020-10-19 13:49:57 +02:00
Christian Hesse
a4b237044d sms-forward: lock against multiple invocations 2020-10-17 13:40:01 +02:00
Christian Hesse
42289b6239 sms-forward: fix usage of function 2020-09-28 19:57:04 +02:00
Christian Hesse
49737af6d1 extend magic pattern with "by RouterOS"
This matches the string included in export.
2020-09-18 11:00:27 +02:00
Christian Hesse
ff5cdc3019 [ ... print count-only ...] -> [ :len [ ... find ... ] ]
Using 'print count-only' always prints a number to terminal, even if the
value is evaluated in a condition or assigned to a variable. This can be
quite annoying. Behavior will not chance (SUP-25503), so replacing the
code...
2020-08-26 09:29:52 +02:00
Christian Hesse
075859c898 global-functions: introduce and use $SymbolForNotification 2020-07-17 08:12:00 +02:00
Christian Hesse
0e7b2d3ac7 sms-forward: use $SymbolByUnicodeName 2020-07-17 07:52:56 +02:00
Christian Hesse
371e96911d sms-forward: add symbol 2020-07-16 14:53:35 +02:00
Christian Hesse
639bfc367b sms-forward: wait to be fully connected 2020-07-14 09:25:12 +02:00
Christian Hesse
71ad56aacc explicitly name the license
Copyright (C) 2013-2020 Christian Hesse <mail@eworm.de>

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

https://www.gnu.org/licenses/#GPL
https://www.gnu.org/licenses/gpl.html
https://www.gnu.org/licenses/gpl.md
2020-06-19 22:17:42 +02:00
Christian Hesse
a806b37a47 sms-forward: warn and exit if receiving is not enabled 2020-05-17 22:34:17 +02:00
Christian Hesse
972a481faa sms-forward: use $LogPrintExit 2020-04-03 17:20:56 +02:00
Christian Hesse
e8bc0a7169 add doc/sms-forward.md 2020-03-27 22:12:49 +01:00
Christian Hesse
001e7eeb39 global-functions: sort alphabetically 2020-02-28 15:26:26 +01:00
Christian Hesse
ceaa83b83e global-functions: merge $LogAnd{Error,Put} to $LogPrintExit ...
... and fix logging.

Logging with severity from variable (:log $severity ...) is not
possible, this is considered a syntax error. Also the 'workaround' with
parsing code failed with missing message in log.

The reliable code is a lot longer, so merge the two functions to save a
lot of duplicate code.
2020-02-26 14:19:54 +01:00
Christian Hesse
3ebf68a08c global-functions: $LogAndError: add severity 2020-02-26 12:09:19 +01:00
Christian Hesse
bb9a4e6ecf sms-forward: use $LogAndError 2020-02-26 11:49:11 +01:00
Christian Hesse
e11ddeaf8c sms-forward: use $MailServerIsUp 2020-02-24 10:48:24 +01:00
Christian Hesse
afb9839073 update copyright for 2020 2020-01-01 17:00:39 +01:00
Christian Hesse
dcd47d8ac4 sms-forward: add sender in subject 2019-08-08 16:15:10 +02:00
Christian Hesse
5408ba008a sms-forward: fix array access in condition 2019-08-05 10:32:19 +02:00
Christian Hesse
1c4dfeaa4a sms-forward: get values into arrays 2019-07-25 14:24:18 +02:00
Christian Hesse
2e10a80f95 sms-forward: group messages for same sender 2019-04-05 09:24:04 +02:00
Christian Hesse
b35c0b8a6f always write warnings and errors to log 2019-04-03 21:30:43 +02:00
Christian Hesse
870f00bb36 global: variable names are CamelCase
___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*
2019-01-04 12:35:34 +01:00
Christian Hesse
472cd3d905 update copyright for 2019 2019-01-02 09:38:34 +01:00
Christian Hesse
6e4d715937 global-functions: add identity tag in $SendNotification
... and send subject in telegram message.
2018-11-28 21:19:39 +01:00
Christian Hesse
1bbbe3a5a7 global: remove unused variables 2018-10-10 21:49:46 +02:00
Christian Hesse
2e64b97888 sms-forward: use function for notification 2018-10-09 15:57:53 +02:00
Christian Hesse
be673737d3 start scripts with a magic token / shebang 2018-09-27 00:18:43 +02:00
Christian Hesse
4273459f11 sms-forward: make handling of SMS with action more robust 2018-09-23 22:27:01 +02:00
Christian Hesse
07e54dd88b add empty comment at first line...
... for better formatting in export.
2018-08-24 16:58:30 +02:00
Christian Hesse
a6d4e5eec8 add script 'sms-action' 2018-08-06 16:05:34 +02:00
Christian Hesse
1972fc32d0 rename forward-sms -> sms-forward 2018-08-06 14:37:28 +02:00
Renamed from forward-sms (Browse further)