Commit graph

25 commits

Author SHA1 Message Date
Christian Hesse f46db91845 global: give script or function name in log messages 2021-02-24 21:51:54 +01:00
Christian Hesse d5afc79eed global: drop script 'global-wait'
All scripts wait for the global functions on their own now.
2021-02-18 21:45:38 +01:00
Christian Hesse 547fbc630a update copyright for 2021 2021-01-01 21:33:52 +01:00
Christian Hesse cbb1e624b2 bridge-port-to-default: be more robust
This was unreliable with inconsistent configuration...
2020-10-23 15:27:17 +02:00
Christian Hesse 49737af6d1 extend magic pattern with "by RouterOS"
This matches the string included in export.
2020-09-18 11:00:27 +02:00
Christian Hesse 5c7cde6227 bridge-port-to-default: better check for non-empty value 2020-09-01 23:39:34 +02:00
Christian Hesse 71ad56aacc explicitly name the license
Copyright (C) 2013-2020 Christian Hesse <mail@eworm.de>

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

https://www.gnu.org/licenses/#GPL
https://www.gnu.org/licenses/gpl.html
https://www.gnu.org/licenses/gpl.md
2020-06-19 22:17:42 +02:00
Christian Hesse 60a21e11b0 add doc/bridge-port.md 2020-03-27 22:12:49 +01:00
Christian Hesse 27e2635007 bridge-port-to-default: use $LogPrintExit for debug 2020-03-05 09:24:10 +01:00
Christian Hesse 628ae1bd70 bridge-port-to-default: use $ParseKeyValueStore...
... and unbreak last commit removing delay (69352c90).
This requires a change in configuration syntax. Change this...

    comment="default:br-local, alt:br-guest"

to...

    comment="default=br-local, alt=br-guest"
2020-03-03 13:32:00 +01:00
Christian Hesse 4ccdec602e bridge-port-to-default: use $LogPrintExit 2020-03-03 08:54:18 +01:00
Christian Hesse 69352c90d5 bridge-port-to-default: drop delay
Now that we expect the scheduler to have a delay and script-updates
warning about it...
2020-02-24 19:47:17 +01:00
Christian Hesse afb9839073 update copyright for 2020 2020-01-01 17:00:39 +01:00
Christian Hesse 44dd4231cb bridge-port-to-default: handle special value 'dhcp-client'...
... which disables the bridge port, but enables a dhcp client.
2019-06-26 00:07:11 +02:00
Christian Hesse 9d1a59fd64 bridge-port-to-default: get bridge port values into array 2019-06-25 23:06:51 +02:00
Christian Hesse 870f00bb36 global: variable names are CamelCase
___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*
2019-01-04 12:35:34 +01:00
Christian Hesse 472cd3d905 update copyright for 2019 2019-01-02 09:38:34 +01:00
Christian Hesse b6e2b8c3e4 bridge-port-to-default: delay only when required 2018-10-25 20:48:48 +02:00
Christian Hesse 6b089a1425 bridge-port-to-default: delay for global-config
All scripts scheduled with "start-time=startup interval=0" start
simultaneously, thus racing on global variables. So delay for
a second and give global-config time to finish.
2018-10-25 12:50:56 +02:00
Christian Hesse b239853303 bridge-port-to-default: drop unused code, :toarray strips itself 2018-10-25 12:15:08 +02:00
Christian Hesse a187a4361a bridge-port-to-default: fix variable name 2018-10-25 11:38:20 +02:00
Christian Hesse 0896d81bb0 bridge-port-to-default: strip leading blank from comment 2018-10-04 22:13:05 +02:00
Christian Hesse 17f64b48af bridge-port-to-default: support different configurations
Just add something like this to your bridge ports:

comment="default:br-ext,alt:br-intern"
2018-10-04 13:56:09 +02:00
Christian Hesse be673737d3 start scripts with a magic token / shebang 2018-09-27 00:18:43 +02:00
Christian Hesse 529acebc7b rename ethernet-to-default -> bridge-port-to-default 2018-08-27 10:16:10 +02:00
Renamed from ethernet-to-default (Browse further)