Commit graph

19 commits

Author SHA1 Message Date
Christian Hesse 554308a399 dhcp-to-dns: use $LogPrintExit 2020-03-05 08:37:12 +01:00
Christian Hesse 001e7eeb39 global-functions: sort alphabetically 2020-02-28 15:26:26 +01:00
Christian Hesse 0560f828d1 dhcp-to-dns: act on bound leases only 2020-01-06 09:40:24 +01:00
Christian Hesse afb9839073 update copyright for 2020 2020-01-01 17:00:39 +01:00
Christian Hesse 845c25f87c dhcp-to-dns: act on hostname only if available 2019-11-14 22:16:33 +01:00
Christian Hesse 395bc8c90f dhcp-to-dns: set the temporary variable unconditionally 2019-11-12 13:02:40 +01:00
Christian Hesse 91776d3388 dhcp-to-dns: handle duplicate mac-address and host-name
* several leases for one mac address (changed client id, different net):
   -> take address from last lease
  Most likely this is the same devices which booted different OS or
  changed to different network.

* several leases for one host name:
   -> take address from first lease
  We see either different devices with same name or one device with
  several network interfaces. Keep the first name to mitigate stealing
  dns name.
2019-11-12 12:49:28 +01:00
Christian Hesse 23b38fa15a dhcp-to-dns: find duplicate leases by mac-address 2019-09-11 12:36:47 +02:00
Christian Hesse 8d4dc1e3f6 dhcp-to-dns: get values into arrays, general rework 2019-07-25 12:55:11 +02:00
Christian Hesse 7fc12f9e24 dhcp-to-dns: rework, fix cleanup with mac-address and more 2019-02-08 13:43:00 +01:00
Christian Hesse a47aa45253 dhcp-to-dns: use mac-address if hostname is empty 2019-02-08 13:03:42 +01:00
Christian Hesse 0a34f4c2c2 dhcp-to-dns: use $CharacterReplace 2019-02-08 13:02:39 +01:00
Christian Hesse 870f00bb36 global: variable names are CamelCase
___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*
2019-01-04 12:35:34 +01:00
Christian Hesse 0f72662745 dhcp-to-dns: give time in short format
Note that a unit is required to make it a time value!
2019-01-03 10:28:23 +01:00
Christian Hesse 472cd3d905 update copyright for 2019 2019-01-02 09:38:34 +01:00
Christian Hesse 3e9c5a3b6d dhcp-to-dns: use 'print count-only' 2018-11-09 21:32:01 +01:00
Christian Hesse be673737d3 start scripts with a magic token / shebang 2018-09-27 00:18:43 +02:00
Christian Hesse 07e54dd88b add empty comment at first line...
... for better formatting in export.
2018-08-24 16:58:30 +02:00
Christian Hesse e1f134ead5 add scripts 2018-07-05 15:34:08 +02:00