Commit graph

27 commits

Author SHA1 Message Date
Christian Hesse
2d30f4e462 check-lte-firmware-upgrade: update initialization of empty array
Having the parenthesis here is important for valid syntax!
2022-07-13 11:32:11 +02:00
Christian Hesse
602933baec check-lte-firmware-upgrade: RouterOS v7 path syntax 2022-05-11 13:48:27 +02:00
Christian Hesse
2aa93a0671 check-lte-firmware-upgrade: rework code and its logic 2022-03-30 17:24:16 +02:00
Christian Hesse
d952e7e6c7 check-lte-firmware-upgrade: support starting unattended firmware upgrade...
... from terminal if script is installed.
2022-03-28 12:39:46 +02:00
Christian Hesse
5aecc9f1a3 check-lte-firmware-upgrade: be more verbose 2022-03-28 12:39:46 +02:00
Christian Hesse
7bd40b34f1 check-lte-firmware-upgrade: fix command for ROS 7.x 2022-03-28 11:42:16 +02:00
Christian Hesse
95e9820718 update copyright for 2022 2022-01-01 21:38:15 +01:00
Christian Hesse
fbe4c457c6 check-lte-firmware-upgrade: pass origin to $SendNotification2 2021-04-28 13:58:37 +02:00
Christian Hesse
4fe11fadee check-lte-firmware-upgrade: use $SendNotification2 2021-04-28 13:58:37 +02:00
Christian Hesse
f46db91845 global: give script or function name in log messages 2021-02-24 21:51:54 +01:00
Christian Hesse
d5afc79eed global: drop script 'global-wait'
All scripts wait for the global functions on their own now.
2021-02-18 21:45:38 +01:00
Christian Hesse
17d7678e2d global-functions: drop support for attachment in notification e-mail 2021-02-16 16:04:18 +01:00
Christian Hesse
547fbc630a update copyright for 2021 2021-01-01 21:33:52 +01:00
Christian Hesse
ca4e25283f global-functions: clickable links in telegram notifications 2020-11-26 23:04:05 +01:00
Christian Hesse
e11e6b4658 check-lte-firmware-upgrade: show manufacturer & model 2020-10-13 13:23:32 +02:00
Christian Hesse
49737af6d1 extend magic pattern with "by RouterOS"
This matches the string included in export.
2020-09-18 11:00:27 +02:00
Christian Hesse
00e99a13fb check-lte-firmware-upgrade: add symbol in notification 2020-07-17 12:26:55 +02:00
Christian Hesse
71ad56aacc explicitly name the license
Copyright (C) 2013-2020 Christian Hesse <mail@eworm.de>

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

https://www.gnu.org/licenses/#GPL
https://www.gnu.org/licenses/gpl.html
https://www.gnu.org/licenses/gpl.md
2020-06-19 22:17:42 +02:00
Christian Hesse
06c8f279f8 check-lte-firmware-upgrade: give current and available version 2020-04-07 21:51:41 +02:00
Christian Hesse
ee903e263f check-lte-firmware-upgrade: use $LogPrintExit 2020-04-03 17:19:34 +02:00
Christian Hesse
969ae57fc2 add doc/check-lte-firmware-upgrade.md 2020-03-27 22:12:49 +01:00
Christian Hesse
afb9839073 update copyright for 2020 2020-01-01 17:00:39 +01:00
Christian Hesse
a78d9d0470 check-lte-firmware-upgrade: make notification silent 2019-08-18 21:30:59 +02:00
Christian Hesse
a2e6362967 check-lte-firmware-upgrade: drop literal 'notification' 2019-05-23 12:19:01 +02:00
Christian Hesse
f60d99a254 check-lte-firmware-upgrade: remove workaround
This is fixed in 6.44beta75.
2019-02-11 16:21:28 +01:00
Christian Hesse
870f00bb36 global: variable names are CamelCase
___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*
2019-01-04 12:35:34 +01:00
Christian Hesse
fe04b8b8db rename script 'check-lte-firmware-update' -> 'check-lte-firmware-upgrade'
That's the correct wording from commands..
2019-01-02 22:50:23 +01:00
Renamed from check-lte-firmware-update (Browse further)