Commit graph

32 commits

Author SHA1 Message Date
Christian Hesse 4d26dd07c3 capsman-download-packages: wireless package does no longer exist
This is a RouterOS v7 only change!
2022-02-10 12:29:31 +01:00
Christian Hesse 95e9820718 update copyright for 2022 2022-01-01 21:38:15 +01:00
Christian Hesse 041ca062b1 global: use $0 for $ScriptLock 2021-02-24 21:51:56 +01:00
Christian Hesse f46db91845 global: give script or function name in log messages 2021-02-24 21:51:54 +01:00
Christian Hesse 9975709ab7 capsman-download-packages: give more context in output 2021-02-21 21:40:28 +01:00
Christian Hesse 940d31b555 capsman-download-packages: complain on undefined path 2021-02-21 21:36:34 +01:00
Christian Hesse d5afc79eed global: drop script 'global-wait'
All scripts wait for the global functions on their own now.
2021-02-18 21:45:38 +01:00
Christian Hesse 99aaf642b2 capsman-download-packages: handle error when creating directory 2021-01-20 14:43:27 +01:00
Christian Hesse 547fbc630a update copyright for 2021 2021-01-01 21:33:52 +01:00
Christian Hesse 49737af6d1 extend magic pattern with "by RouterOS"
This matches the string included in export.
2020-09-18 11:00:27 +02:00
Christian Hesse ff5cdc3019 [ ... print count-only ...] -> [ :len [ ... find ... ] ]
Using 'print count-only' always prints a number to terminal, even if the
value is evaluated in a condition or assigned to a variable. This can be
quite annoying. Behavior will not chance (SUP-25503), so replacing the
code...
2020-08-26 09:29:52 +02:00
Christian Hesse 0b5ab83339 capsman-download-packages: wait to be fully connected 2020-07-14 14:29:29 +02:00
Christian Hesse 71ad56aacc explicitly name the license
Copyright (C) 2013-2020 Christian Hesse <mail@eworm.de>

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

https://www.gnu.org/licenses/#GPL
https://www.gnu.org/licenses/gpl.html
https://www.gnu.org/licenses/gpl.md
2020-06-19 22:17:42 +02:00
Christian Hesse 2cd8a56aa7 capsman-download-packages: create package path 2020-04-06 12:46:46 +02:00
Christian Hesse 74d192cf53 add doc/capsman-download-packages.md 2020-03-27 22:12:49 +01:00
Christian Hesse afb9839073 update copyright for 2020 2020-01-01 17:00:39 +01:00
Christian Hesse b8db93918f capsman-download-packages: lock against multiple invocation 2019-12-05 11:41:49 +01:00
Christian Hesse 67f4b135f5 capsman-download-packages: syntax error with missing parenthesis 2019-08-02 15:22:17 +02:00
Christian Hesse e7dffe0a82 capsman-download-packages: get values into array 2019-07-25 10:35:15 +02:00
Christian Hesse e309dee3b1 capsman-download-packages: do not require extra permission
The idea was to run capsman-download-packages from netwatch when
upgrade.mikrotik.com is up.

Instead run it from scheduler at startup, but add a delay:

/ system scheduler add name=capsman-download-packages \
    on-event=":delay 2m; capsman-download-packages" start-time=startup
2019-07-18 14:00:53 +02:00
Christian Hesse 74683b3fc8 capsman-download-packages: split off capsman-rolling-upgrade 2019-02-14 20:49:05 +01:00
Christian Hesse 151435ba0c capsman-download-packages: use $CleanFilePath 2019-02-13 09:44:45 +01:00
Christian Hesse 4c61849483 capsman-download-packages: upgrade CAPs one after another with delay 2019-02-07 11:04:15 +01:00
Christian Hesse 870f00bb36 global: variable names are CamelCase
___  _         ___     __
           / _ )(_)__ _   / _/__ _/ /_
          / _  / / _ `/  / _/ _ `/ __/
         /____/_/\_, /  /_/ \_,_/\__/
 _       __     /___/       _             __
| |     / /___ __________  (_)___  ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / /  / / / / / / / / /_/ /_/
|__/|__/\__,_/_/  /_/ /_/_/_/ /_/\__, (_)
                                /____/

RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:

[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

That looks ok. Now we use a script:

{ :local interface "en1";
  / interface print where name=$interface; }

And the result...

[admin@MikroTik] > { :local interface "en1";
{...   / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598

... still looks ok.
We make a little modification to the script:

{ :local name "en1";
  / interface print where name=$name; }

And the result:

[admin@MikroTik] > { :local name "en1";
{...   / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU
 0  RS en1                                 ether            1500  1598
 1   S en2                                 ether            1500  1598
 2   S en3                                 ether            1500  1598
 3   S en4                                 ether            1500  1598
 4   S en5                                 ether            1500  1598
 5  R  br-local                            bridge           1500  1598

Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).

And another modification:

{ :local type "en1";
  / interface print where name=$type; }

And the result:

[admin@MikroTik] > { :local type "en1";
{...   / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
 #     NAME                                TYPE       ACTUAL-MTU L2MTU

Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.

The answer from MikroTik support (in Ticket#2019010222000454):

> This is how scripting works in RouterOS and we will not fix it.

To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...

*fingers crossed*
2019-01-04 12:35:34 +01:00
Michael Gisbers 69e76f5ecc capsman-download-packages: use upgrade command to force remote-cap upgrade
Signed-off-by: Michael Gisbers <michael@gisbers.de>
Signed-off-by: Christian Hesse <mail@eworm.de>
2019-01-02 15:02:42 +01:00
Christian Hesse 472cd3d905 update copyright for 2019 2019-01-02 09:38:34 +01:00
Christian Hesse ac2e6cfc61 global-functions: add $DownloadPackage
... and make script 'capsman-download-packages' use it.
2018-12-28 22:56:07 +01:00
Christian Hesse 30166cc287 capsman-download-packages: move condition to loop 2018-12-28 18:50:22 +01:00
Christian Hesse 1131d8ee41 capsman-download-packages: act in package-path only 2018-12-27 21:42:30 +01:00
Christian Hesse 0ecb0749fd capsman-download-packages: do not restart service...
... but disconnect old CAPs and force reconnect with update.
2018-12-27 21:36:31 +01:00
Michael Gisbers e1f5f7254a capsman-download-packages: rewrite package-name from wireless@ to wireless
Signed-off-by: Michael Gisbers <michael@gisbers.de>
Signed-off-by: Christian Hesse <mail@eworm.de>
2018-12-27 21:32:00 +01:00
Christian Hesse ecc475af3e add script 'capsman-download-packages' 2018-12-27 02:19:27 +01:00