ppp-on-up: move code into function

This commit is contained in:
Christian Hesse 2024-03-04 13:48:01 +01:00
parent 492edb4263
commit d6077025b2

View file

@ -8,29 +8,33 @@
# run scripts on ppp up # run scripts on ppp up
# https://git.eworm.de/cgit/routeros-scripts/about/doc/ppp-on-up.md # https://git.eworm.de/cgit/routeros-scripts/about/doc/ppp-on-up.md
:local 0 [ :jobname ];
:global GlobalFunctionsReady; :global GlobalFunctionsReady;
:while ($GlobalFunctionsReady != true) do={ :delay 500ms; } :while ($GlobalFunctionsReady != true) do={ :delay 500ms; }
:global LogPrintExit2; :local Main do={
:local ScriptName [ :tostr $1 ];
:local Interface $2;
:local Interface $interface; :global LogPrintExit2;
:if ([ :typeof $Interface ] = "nothing") do={ :if ([ :typeof $Interface ] = "nothing") do={
$LogPrintExit2 error $0 ("This script is supposed to run from ppp on-up script hook.") true; $LogPrintExit2 error $ScriptName ("This script is supposed to run from ppp on-up script hook.") true;
} }
:local IntName [ /interface/get $Interface name ]; :local IntName [ /interface/get $Interface name ];
$LogPrintExit2 info $0 ("PPP interface " . $IntName . " is up.") false; $LogPrintExit2 info $ScriptName ("PPP interface " . $IntName . " is up.") false;
/ipv6/dhcp-client/release [ find where interface=$IntName !disabled ]; /ipv6/dhcp-client/release [ find where interface=$IntName !disabled ];
:foreach Script in=[ /system/script/find where source~("\n# provides: ppp-on-up\n") ] do={ :foreach Script in=[ /system/script/find where source~("\n# provides: ppp-on-up\n") ] do={
:local ScriptName [ /system/script/get $Script name ]; :local ScriptName [ /system/script/get $Script name ];
:do { :do {
$LogPrintExit2 debug $0 ("Running script: " . $ScriptName) false; $LogPrintExit2 debug $ScriptName ("Running script: " . $ScriptName) false;
/system/script/run $Script; /system/script/run $Script;
} on-error={ } on-error={
$LogPrintExit2 warning $0 ("Running script '" . $ScriptName . "' failed!") false; $LogPrintExit2 warning $ScriptName ("Running script '" . $ScriptName . "' failed!") false;
}
} }
} }
$Main [ :jobname ] $interface;