netwatch-notify: fix handling of array

Looks like handling of more-dimensional arrays is a bit tricky in
RouterOS... Without this *all* values with the same key name are
updated, independent of intermediate name.
This commit is contained in:
Christian Hesse 2020-03-05 12:42:21 +01:00
parent 3d07ebde05
commit 9aed03693c

View file

@ -17,23 +17,25 @@
:local HostVal [ / tool netwatch get $Host ]; :local HostVal [ / tool netwatch get $Host ];
:local HostName ([ $ParseKeyValueStore ($HostVal->"comment") ]->"hostname"); :local HostName ([ $ParseKeyValueStore ($HostVal->"comment") ]->"hostname");
:if ([ :typeof ($NetwatchNotify->$HostName) ] = "nothing") do={ :local Metric { "count"=0; "notified"=false };
:set ($NetwatchNotify->$HostName) { "count"=0; "notified"=false }; :if ([ :typeof ($NetwatchNotify->$HostName) ] = "array") do={
:set $Metric ($NetwatchNotify->$HostName);
} }
:if ($HostVal->"status" = "up") do={ :if ($HostVal->"status" = "up") do={
:set ($NetwatchNotify->$HostName->"count") 0; :set ($Metric->"count") 0;
:if ($NetwatchNotify->$HostName->"notified" = true) do={ :if ($Metric->"notified" = true) do={
$SendNotification ("Netwatch Notify: " . $HostName . " up") \ $SendNotification ("Netwatch Notify: " . $HostName . " up") \
("Host " . $HostName . " (" . $HostVal->"host" . ") is up since " . $HostVal->"since" . "."); ("Host " . $HostName . " (" . $HostVal->"host" . ") is up since " . $HostVal->"since" . ".");
} }
:set ($NetwatchNotify->$HostName->"notified") false; :set ($Metric->"notified") false;
} else={ } else={
:set ($NetwatchNotify->$HostName->"count") ($NetwatchNotify->$HostName->"count" + 1); :set ($Metric->"count") ($Metric->"count" + 1);
:if ($NetwatchNotify->$HostName->"count" >= 5 && $NetwatchNotify->$HostName->"notified" != true) do={ :if ($Metric->"count" >= 5 && $Metric->"notified" != true) do={
$SendNotification ("Netwatch Notify: " . $HostName . " down") \ $SendNotification ("Netwatch Notify: " . $HostName . " down") \
("Host " . $HostName . " (" . $HostVal->"host" . ") is down since " . $HostVal->"since" . "."); ("Host " . $HostName . " (" . $HostVal->"host" . ") is down since " . $HostVal->"since" . ".");
:set ($NetwatchNotify->$HostName->"notified") true; :set ($Metric->"notified") true;
} }
} }
:set ($NetwatchNotify->$HostName) { "count"=($Metric->"count"); "notified"=($Metric->"notified") };
} }