mirror of
https://github.com/eworm-de/routeros-scripts
synced 2024-05-14 08:04:19 +00:00
check-certificates: try all SANs for download
This commit is contained in:
parent
922dde3ff0
commit
9617095022
4 changed files with 21 additions and 6 deletions
|
@ -16,11 +16,13 @@
|
||||||
:global Identity;
|
:global Identity;
|
||||||
|
|
||||||
:global CertificateAvailable
|
:global CertificateAvailable
|
||||||
|
:global EscapeForRegEx;
|
||||||
:global IfThenElse;
|
:global IfThenElse;
|
||||||
:global LogPrintExit2;
|
:global LogPrintExit2;
|
||||||
:global ParseKeyValueStore;
|
:global ParseKeyValueStore;
|
||||||
:global SendNotification2;
|
:global SendNotification2;
|
||||||
:global SymbolForNotification;
|
:global SymbolForNotification;
|
||||||
|
:global UrlEncode;
|
||||||
:global WaitFullyConnected;
|
:global WaitFullyConnected;
|
||||||
|
|
||||||
:local CheckCertificatesDownloadImport do={
|
:local CheckCertificatesDownloadImport do={
|
||||||
|
@ -56,7 +58,8 @@
|
||||||
$LogPrintExit2 warning $0 ("Decryption failed for certificate file " . $CertFileName) false;
|
$LogPrintExit2 warning $0 ("Decryption failed for certificate file " . $CertFileName) false;
|
||||||
}
|
}
|
||||||
|
|
||||||
:foreach CertInChain in=[ /certificate/find where name~("^" . $CertFileName . "_[0-9]+\$") common-name!=$Name !(common-name=[]) ] do={
|
:foreach CertInChain in=[ /certificate/find where name~("^" . $CertFileName . "_[0-9]+\$") \
|
||||||
|
common-name!=$Name !(subject-alt-name~("(^|\\W)(DNS|IP):" . [ $EscapeForRegEx $Name ] . "(\\W|\$)")) !(common-name=[]) ] do={
|
||||||
$CertificateNameByCN [ /certificate/get $CertInChain common-name ];
|
$CertificateNameByCN [ /certificate/get $CertInChain common-name ];
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -105,6 +108,7 @@ $WaitFullyConnected;
|
||||||
|
|
||||||
:foreach Cert in=[ /certificate/find where !revoked !ca !scep-url expires-after<$CertRenewTime ] do={
|
:foreach Cert in=[ /certificate/find where !revoked !ca !scep-url expires-after<$CertRenewTime ] do={
|
||||||
:local CertVal [ /certificate/get $Cert ];
|
:local CertVal [ /certificate/get $Cert ];
|
||||||
|
:local LastName;
|
||||||
|
|
||||||
:do {
|
:do {
|
||||||
:if ([ :len $CertRenewUrl ] = 0) do={
|
:if ([ :len $CertRenewUrl ] = 0) do={
|
||||||
|
@ -113,9 +117,18 @@ $WaitFullyConnected;
|
||||||
$LogPrintExit2 info $0 ("Attempting to renew certificate " . ($CertVal->"name") . ".") false;
|
$LogPrintExit2 info $0 ("Attempting to renew certificate " . ($CertVal->"name") . ".") false;
|
||||||
|
|
||||||
:local ImportSuccess false;
|
:local ImportSuccess false;
|
||||||
:set ImportSuccess [ $CheckCertificatesDownloadImport ($CertVal->"common-name") ];
|
:set LastName ($CertVal->"common-name");
|
||||||
|
:set ImportSuccess [ $CheckCertificatesDownloadImport $LastName ];
|
||||||
|
:foreach SAN in=($CertVal->"subject-alt-name") do={
|
||||||
|
:if ($ImportSuccess = false) do={
|
||||||
|
:set LastName [ :pick $SAN ([ :find $SAN ":" ] + 1) [ :len $SAN ] ];
|
||||||
|
:set ImportSuccess [ $CheckCertificatesDownloadImport $LastName ];
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
:local CertNew [ /certificate/find where common-name=($CertVal->"common-name") fingerprint!=[ :tostr ($CertVal->"fingerprint") ] expires-after>$CertRenewTime ];
|
:local CertNew [ /certificate/find where name~("^" . [ $EscapeForRegEx [ $UrlEncode $LastName ] ] . "\\.(p12|pem)_[0-9]+\$") \
|
||||||
|
(common-name=($CertVal->"common-name") or subject-alt-name~("(^|\\W)(DNS|IP):" . [ $EscapeForRegEx $LastName ] . "(\\W|\$)")) \
|
||||||
|
fingerprint!=[ :tostr ($CertVal->"fingerprint") ] expires-after>$CertRenewTime ];
|
||||||
:local CertNewVal [ /certificate/get $CertNew ];
|
:local CertNewVal [ /certificate/get $CertNew ];
|
||||||
|
|
||||||
:if ([ $CertificateAvailable ([ $ParseKeyValueStore ($CertNewVal->"issuer") ]->"CN") ] = false) do={
|
:if ([ $CertificateAvailable ([ $ParseKeyValueStore ($CertNewVal->"issuer") ]->"CN") ] = false) do={
|
||||||
|
|
|
@ -34,8 +34,9 @@ in `global-config-overlay`, these are the parameters:
|
||||||
* `CertRenewUrl`: the url to download certificates from
|
* `CertRenewUrl`: the url to download certificates from
|
||||||
* `CertWarnTime`: on what remaining time to warn via notification
|
* `CertWarnTime`: on what remaining time to warn via notification
|
||||||
|
|
||||||
Certificates on the web server should be named `CN.pem` (`PEM` format) or
|
Certificates on the web server should be named by their common name, like
|
||||||
`CN.p12` (`PKCS#12` format).
|
`CN.pem` (`PEM` format) or`CN.p12` (`PKCS#12` format). Alternatively any
|
||||||
|
subject alternative name (aka *Subject Alt Name* or *SAN*) can be used.
|
||||||
|
|
||||||
Also notification settings are required for
|
Also notification settings are required for
|
||||||
[e-mail](mod/notification-email.md),
|
[e-mail](mod/notification-email.md),
|
||||||
|
|
|
@ -12,7 +12,7 @@
|
||||||
:local 0 "global-functions";
|
:local 0 "global-functions";
|
||||||
|
|
||||||
# expected configuration version
|
# expected configuration version
|
||||||
:global ExpectedConfigVersion 97;
|
:global ExpectedConfigVersion 98;
|
||||||
|
|
||||||
# global variables not to be changed by user
|
# global variables not to be changed by user
|
||||||
:global GlobalFunctionsReady false;
|
:global GlobalFunctionsReady false;
|
||||||
|
|
|
@ -11,6 +11,7 @@
|
||||||
:global GlobalConfigChanges {
|
:global GlobalConfigChanges {
|
||||||
96="Added support for notes in 'netwatch-notify', these are included verbatim into the notification.";
|
96="Added support for notes in 'netwatch-notify', these are included verbatim into the notification.";
|
||||||
97="Modified 'dhcp-to-dns' to always add A records for names with mac address, and optionally add CNAME records if the host name is available.";
|
97="Modified 'dhcp-to-dns' to always add A records for names with mac address, and optionally add CNAME records if the host name is available.";
|
||||||
|
98="Extended 'check-certificates' to download new certificate by SubjectAltNames if download by CommonName fails.";
|
||||||
};
|
};
|
||||||
|
|
||||||
# Migration steps to be applied on script updates
|
# Migration steps to be applied on script updates
|
||||||
|
|
Loading…
Reference in a new issue