Crash_Override/routeros-scripts
1
0
Fork 0
mirror of https://github.com/eworm-de/routeros-scripts synced 2024-05-14 08:04:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

netwatch-notify: add error handling for hooks

Browse source 
We already had syntax validation, but a script with valid synctax can
still fail to run...
This commit is contained in:
Christian Hesse 2021-07-08 13:02:57 +02:00
parent 1eb337d87f
commit 87ce4a86b7
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
netwatch-notify
View file

@ -66,7 +66,11 @@
:if ([ $ValidateSyntax ($HostInfo->"up-hook") ] = true) do={
$LogPrintExit2 info $0 ("Running hook on host " . $HostName . " up: " . ($HostInfo->"up-hook")) false;
:set Message ($Message . "\n\nRunning hook:\n" . $HostInfo->"up-hook");
[ :parse ($HostInfo->"up-hook") ];
:do {
[ :parse ($HostInfo->"up-hook") ];
} on-error={
$LogPrintExit2 warning $0 ("The up-hook for host " . $HostName . " failed to run.") false;
}
} else={
$LogPrintExit2 warning $0 ("The up-hook for host " . $HostName . " failed syntax validation.") false;
}
@ -106,7 +110,11 @@
:if ([ $ValidateSyntax ($HostInfo->"down-hook") ] = true) do={
$LogPrintExit2 info $0 ("Running hook on host " . $HostName . " down: " . ($HostInfo->"down-hook")) false;
:set Message ($Message . "\n\nRunning hook:\n" . $HostInfo->"down-hook");
[ :parse ($HostInfo->"down-hook") ];
:do {
[ :parse ($HostInfo->"down-hook") ];
} on-error={
$LogPrintExit2 warning $0 ("The down-hook for host " . $HostName . " failed to run.") false;
}
} else={
$LogPrintExit2 warning $0 ("The down-hook for host " . $HostName . " failed syntax validation.") false;
}