2020-09-18 09:00:27 +00:00
|
|
|
#!rsc by RouterOS
|
2018-07-05 13:29:26 +00:00
|
|
|
# RouterOS script: rotate-ntp
|
2022-01-01 20:38:15 +00:00
|
|
|
# Copyright (c) 2013-2022 Christian Hesse <mail@eworm.de>
|
2020-06-19 20:17:42 +00:00
|
|
|
# https://git.eworm.de/cgit/routeros-scripts/about/COPYING.md
|
2018-07-05 13:29:26 +00:00
|
|
|
#
|
|
|
|
|
# rotate the ntp servers
|
2020-03-27 20:49:51 +00:00
|
|
|
# https://git.eworm.de/cgit/routeros-scripts/about/doc/rotate-ntp.md
|
2018-07-05 13:29:26 +00:00
|
|
|
|
2021-02-22 14:14:10 +00:00
|
|
|
:local 0 "rotate-ntp";
|
2021-02-18 13:52:47 +00:00
|
|
|
:global GlobalFunctionsReady;
|
|
|
|
|
:while ($GlobalFunctionsReady != true) do={ :delay 500ms; }
|
|
|
|
|
|
global: variable names are CamelCase
___ _ ___ __
/ _ )(_)__ _ / _/__ _/ /_
/ _ / / _ `/ / _/ _ `/ __/
/____/_/\_, / /_/ \_,_/\__/
_ __ /___/ _ __
| | / /___ __________ (_)___ ____ _/ /
| | /| / / __ `/ ___/ __ \/ / __ \/ __ `/ /
| |/ |/ / /_/ / / / / / / / / / / /_/ /_/
|__/|__/\__,_/_/ /_/ /_/_/_/ /_/\__, (_)
/____/
RouterOS has some odd behavior when it comes to variable names. Let's
have a look at the interfaces:
[admin@MikroTik] > / interface print where name=en1
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
That looks ok. Now we use a script:
{ :local interface "en1";
/ interface print where name=$interface; }
And the result...
[admin@MikroTik] > { :local interface "en1";
{... / interface print where name=$interface; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
... still looks ok.
We make a little modification to the script:
{ :local name "en1";
/ interface print where name=$name; }
And the result:
[admin@MikroTik] > { :local name "en1";
{... / interface print where name=$name; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
0 RS en1 ether 1500 1598
1 S en2 ether 1500 1598
2 S en3 ether 1500 1598
3 S en4 ether 1500 1598
4 S en5 ether 1500 1598
5 R br-local bridge 1500 1598
Ups! The filter has no effect!
That happens whenever the variable name ($name) matches the property
name (name=).
And another modification:
{ :local type "en1";
/ interface print where name=$type; }
And the result:
[admin@MikroTik] > { :local type "en1";
{... / interface print where name=$type; }
Flags: D - dynamic, X - disabled, R - running, S - slave
# NAME TYPE ACTUAL-MTU L2MTU
Ups! Nothing?
Even if the variable name ($type) matches whatever property name (type=)
things go wrong.
The answer from MikroTik support (in Ticket#2019010222000454):
> This is how scripting works in RouterOS and we will not fix it.
To get around this we use variable names in CamelCase. Let's hope
Mikrotik never ever introduces property names in CamelCase...
*fingers crossed*
2019-01-03 16:45:43 +00:00
|
|
|
:global NtpPool;
|
2018-07-05 13:29:26 +00:00
|
|
|
|
2021-02-22 14:14:10 +00:00
|
|
|
:global LogPrintExit2;
|
2020-03-05 08:42:28 +00:00
|
|
|
|
2020-05-15 18:10:24 +00:00
|
|
|
:local Ntp1;
|
|
|
|
|
:local Ntp2;
|
2018-07-05 13:29:26 +00:00
|
|
|
|
2018-09-18 21:46:24 +00:00
|
|
|
:if ([ / system ntp client get enabled ] != true) do={
|
2021-02-22 14:14:10 +00:00
|
|
|
$LogPrintExit2 warning $0 ("NTP client is not enabled!") true;
|
2018-09-18 21:46:24 +00:00
|
|
|
}
|
|
|
|
|
|
2020-05-15 18:10:24 +00:00
|
|
|
:do {
|
|
|
|
|
:set Ntp1 [ :resolve ("0." . $NtpPool) ];
|
|
|
|
|
:set Ntp2 [ :resolve ("1." . $NtpPool) ];
|
|
|
|
|
} on-error={
|
2021-02-22 14:14:10 +00:00
|
|
|
$LogPrintExit2 warning $0 ("Resolving NTP server failed.") true;
|
2020-05-15 18:10:24 +00:00
|
|
|
}
|
|
|
|
|
|
2021-02-22 14:14:10 +00:00
|
|
|
$LogPrintExit2 info $0 ("Updating NTP servers to " . $Ntp1 . " and " . $Ntp2) false;
|
2021-09-30 10:10:57 +00:00
|
|
|
/ system ntp client set servers=($Ntp1, $Ntp2);
|