From 81319297ec68b95fd247c899cadc323e0ab4f0ac Mon Sep 17 00:00:00 2001 From: Carsten Schmiemann Date: Thu, 14 Apr 2022 17:55:06 +0200 Subject: [PATCH] Fix EVC pids --- .../src/vehicle_renaultzoe_ph2.cpp | 25 +++++++++---------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/vehicle_renaultzoe_ph2.cpp b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/vehicle_renaultzoe_ph2.cpp index 351fe63..d5c1e5f 100644 --- a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/vehicle_renaultzoe_ph2.cpp +++ b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/vehicle_renaultzoe_ph2.cpp @@ -82,7 +82,7 @@ static const OvmsVehicle::poll_pid_t renault_zoe_polls[] = { //EVC-HCM-VCM //{ 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIISESSION, SESSION_EXTDIAG, { 60, 60, 60, 60 }, 0, ISOTP_EXTFRAME }, // OBD Extended Diagnostic Session { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2006, { 180, 10, 10, 300 }, 0, ISOTP_EXTFRAME }, // Odometer - { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x29FD, { 0, 10, 5, 3 }, 0, ISOTP_EXTFRAME }, // 12Battery Current + { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2A8C, { 0, 10, 5, 3 }, 0, ISOTP_EXTFRAME }, // 12Battery Current { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2005, { 0, 10, 5, 3 }, 0, ISOTP_EXTFRAME }, // 12Battery Voltage { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x21D0, { 0, 10, 10, 3 }, 0, ISOTP_EXTFRAME }, // DCDC Temperature { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x21CF, { 0, 10, 10, 300 }, 0, ISOTP_EXTFRAME }, // Inverter Status @@ -297,10 +297,9 @@ void OvmsVehicleRenaultZoePh2::IncomingEVC(uint16_t type, uint16_t pid, const ch } break; } - case 0x29FD: { - StandardMetrics.ms_v_charge_12v_current->SetValue((float) (CAN_UINT(0) - 327.675), Amps); - ESP_LOGD(TAG, "29FD EVC ms_v_charge_12v_current: %d", CAN_UINT(0)); - ESP_LOGD(TAG, "29FD EVC ms_v_charge_12v_current: %f", CAN_UINT(0) - 327.675); + case 0x2A8C: { + StandardMetrics.ms_v_charge_12v_current->SetValue((float) (CAN_UINT(0)), Amps); + ESP_LOGD(TAG, "2A8C EVC ms_v_charge_12v_current: %d", CAN_UINT(0)); break; } case 0x2005: { @@ -309,8 +308,8 @@ void OvmsVehicleRenaultZoePh2::IncomingEVC(uint16_t type, uint16_t pid, const ch break; } case 0x21D0: { - StandardMetrics.ms_v_charge_12v_temp->SetValue((float) (CAN_UINT(0) - 40), Celcius); - ESP_LOGD(TAG, "21D0 EVC ms_v_charge_12v_temp: %d", CAN_UINT(0) - 40); + StandardMetrics.ms_v_charge_12v_temp->SetValue((float) (CAN_UINT(4) - 40), Celcius); + ESP_LOGD(TAG, "21D0 EVC ms_v_charge_12v_temp: %d", CAN_UINT(4) - 40); break; } case 0x21CF: { @@ -331,18 +330,18 @@ void OvmsVehicleRenaultZoePh2::IncomingEVC(uint16_t type, uint16_t pid, const ch break; } case 0xF446: { // Ambient temperature - StandardMetrics.ms_v_env_temp->SetValue((float) (CAN_UINT(0) - 40) * 0.01, Celcius); - ESP_LOGD(TAG, "F446 EVC ms_v_env_temp: %f", (CAN_UINT(0) - 40) * 0.01); + StandardMetrics.ms_v_env_temp->SetValue((float) (CAN_UINT(4) - 40) * 0.01, Celcius); + ESP_LOGD(TAG, "F446 EVC ms_v_env_temp: %f", (CAN_UINT(4) - 40) * 0.01); break; } case 0x2A09: { // Power consumption by consumer - mt_aux_power_consumer->SetValue((float) CAN_UINT(0) * 10, Watts); - ESP_LOGD(TAG, "2A09 EVC mt_aux_power_consumer: %d", CAN_UINT(0) * 10); + mt_aux_power_consumer->SetValue((float) CAN_UINT(4) * 10, Watts); + ESP_LOGD(TAG, "2A09 EVC mt_aux_power_consumer: %d", CAN_UINT(4) * 10); break; } case 0x2191: { // Power consumption by ptc - mt_aux_power_ptc->SetValue((float) CAN_UINT(0) * 10, Watts); - ESP_LOGD(TAG, "2191 EVC mt_aux_power_ptc: %d", CAN_UINT(0) * 10); + mt_aux_power_ptc->SetValue((float) CAN_UINT(4) * 10, Watts); + ESP_LOGD(TAG, "2191 EVC mt_aux_power_ptc: %d", CAN_UINT(4) * 10); break; } }