From 7418f08f6f11485e315d7b7898e5aacb46855f2f Mon Sep 17 00:00:00 2001 From: Carsten Schmiemann Date: Sat, 16 Apr 2022 15:32:15 +0200 Subject: [PATCH] Fix temp PIDs and BMS logging --- .../vehicle_renaultzoe_ph2/src/EVC_pids.cpp | 16 ++++++++-------- .../vehicle_renaultzoe_ph2/src/LBC_pids.cpp | 4 ++++ .../vehicle_renaultzoe_ph2/src/UCM_pids.cpp | 4 +++- .../vehicle_renaultzoe_ph2/src/ph2_poller.h | 5 +++-- 4 files changed, 18 insertions(+), 11 deletions(-) diff --git a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/EVC_pids.cpp b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/EVC_pids.cpp index 53c1d41..a9e1459 100644 --- a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/EVC_pids.cpp +++ b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/EVC_pids.cpp @@ -32,11 +32,11 @@ void OvmsVehicleRenaultZoePh2::IncomingEVC(uint16_t type, uint16_t pid, const ch ESP_LOGD(TAG, "2006 EVC ms_v_pos_odometer: %d", CAN_UINT24(0)); break; } - case 0x2A8C: { //12V Battery Current - StandardMetrics.ms_v_charge_12v_current->SetValue((float) (CAN_UINT(0)), Amps); - ESP_LOGD(TAG, "2A8C EVC ms_v_charge_12v_current: %d", CAN_UINT(0)); - break; - } + //case 0x2A8C: { //12V Battery Current + // StandardMetrics.ms_v_charge_12v_current->SetValue((float) (CAN_UINT(0)), Amps); + // ESP_LOGD(TAG, "2A8C EVC ms_v_charge_12v_current: %d", CAN_UINT(0)); + // break; + //} case 0x2005: { //12V Battery Voltage StandardMetrics.ms_v_charge_12v_voltage->SetValue((float) (CAN_UINT(0) * 0.01), Volts); ESP_LOGD(TAG, "2005 EVC ms_v_charge_12v_voltage: %f", CAN_UINT(0) * 0.01); @@ -64,9 +64,9 @@ void OvmsVehicleRenaultZoePh2::IncomingEVC(uint16_t type, uint16_t pid, const ch } break; } - case 0xF446: { // Ambient temperature - StandardMetrics.ms_v_env_temp->SetValue((float) (CAN_UINT(4) - 40) * 0.01, Celcius); - ESP_LOGD(TAG, "F446 EVC ms_v_env_temp: %f", (CAN_UINT(4) - 40) * 0.01); + case 0x2218: { // Ambient temperature + StandardMetrics.ms_v_env_temp->SetValue((float) (CAN_UINT(0) * 0.1 - 273), Celcius); + ESP_LOGD(TAG, "2218 EVC ms_v_env_temp: %f", (CAN_UINT(0) * 0.1 - 273)); break; } case 0x2A09: { // Power consumption by consumer diff --git a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/LBC_pids.cpp b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/LBC_pids.cpp index 415248c..18a335d 100644 --- a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/LBC_pids.cpp +++ b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/LBC_pids.cpp @@ -80,11 +80,13 @@ void OvmsVehicleRenaultZoePh2::IncomingLBC(uint16_t type, uint16_t pid, const ch } case 0x9014: { //Cell Max Temp StandardMetrics.ms_v_bat_pack_tmax->SetValue((float) (CAN_UINT(0) * 0.625 - 40), Celcius); + ESP_LOGD(TAG, "9014 LBC ms_v_bat_pack_tmax RAW: %d", CAN_UINT(0)); ESP_LOGD(TAG, "9014 LBC ms_v_bat_pack_tmax: %f", CAN_UINT(0) * 0.625 - 40); break; } case 0x9013: { //Cell Min Temp StandardMetrics.ms_v_bat_pack_tmin->SetValue((float) (CAN_UINT(0) * 0.625 - 40), Celcius); + ESP_LOGD(TAG, "9013 LBC ms_v_bat_pack_tmin RAW: %d", CAN_UINT(0)); ESP_LOGD(TAG, "9013 LBC ms_v_bat_pack_tmin: %f", CAN_UINT(0) * 0.625 - 40); break; } @@ -100,6 +102,7 @@ void OvmsVehicleRenaultZoePh2::IncomingLBC(uint16_t type, uint16_t pid, const ch } case 0x9131: { BmsSetCellTemperature(1, CAN_UINT(0) * 0.625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); break; } case 0x9132: { @@ -148,6 +151,7 @@ void OvmsVehicleRenaultZoePh2::IncomingLBC(uint16_t type, uint16_t pid, const ch } case 0x9021: { BmsSetCellVoltage(1, CAN_UINT(0) * 0.001); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.001); break; } case 0x9022: { diff --git a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/UCM_pids.cpp b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/UCM_pids.cpp index e09c3f7..24073b4 100644 --- a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/UCM_pids.cpp +++ b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/UCM_pids.cpp @@ -26,7 +26,9 @@ void OvmsVehicleRenaultZoePh2::IncomingUCM(uint16_t type, uint16_t pid, const char* data, uint16_t len) { switch (pid) { - case 0x001: { + case 0x6079: { //12V Battery Current + StandardMetrics.ms_v_charge_12v_current->SetValue((float) (CAN_UINT(0) * 0.1), Amps); + ESP_LOGD(TAG, "6079 UCM ms_v_charge_12v_current: %f", CAN_UINT(0) * 0.1); break; } diff --git a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/ph2_poller.h b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/ph2_poller.h index f8fe37f..9873baf 100644 --- a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/ph2_poller.h +++ b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/ph2_poller.h @@ -46,12 +46,12 @@ static const OvmsVehicle::poll_pid_t renault_zoe_polls[] = { //EVC-HCM-VCM //{ 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIISESSION, SESSION_EXTDIAG, { 60, 60, 60, 60 }, 0, ISOTP_EXTFRAME }, // OBD Extended Diagnostic Session { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2006, { 0, 10, 10, 300 }, 0, ISOTP_EXTFRAME }, // Odometer -{ 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2A8C, { 0, 10, 5, 3 }, 0, ISOTP_EXTFRAME }, // 12Battery Current +//{ 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2A8C, { 0, 10, 5, 3 }, 0, ISOTP_EXTFRAME }, // 12Battery Current { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2005, { 0, 10, 5, 3 }, 0, ISOTP_EXTFRAME }, // 12Battery Voltage { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x21D0, { 0, 10, 10, 3 }, 0, ISOTP_EXTFRAME }, // DCDC Temperature { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x21CF, { 0, 10, 10, 300 }, 0, ISOTP_EXTFRAME }, // Inverter Status { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x303D, { 0, 10, 10, 3 }, 0, ISOTP_EXTFRAME }, // HV Battery Insulation Resistance -{ 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0xF446, { 0, 10, 10, 10 }, 0, ISOTP_EXTFRAME }, // Ambient Temperature +{ 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2218, { 0, 10, 10, 10 }, 0, ISOTP_EXTFRAME }, // Ambient Temperature { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2A09, { 0, 10, 10, 10 }, 0, ISOTP_EXTFRAME }, // Power usage by consumer { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2191, { 0, 10, 10, 10 }, 0, ISOTP_EXTFRAME }, // Power usage by ptc @@ -202,5 +202,6 @@ static const OvmsVehicle::poll_pid_t renault_zoe_polls[] = { //UCM //{ 0x1869, 0x1901, VEHICLE_POLL_TYPE_OBDIISESSION, SESSION_EXTDIAG, { 60, 60, 60, 60 }, 0, ISOTP_EXTADR }, // OBD Extended Diagnostic Session +{ 0x1869, 0x1901, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x6079, { 0, 10, 5, 3 }, 0, ISOTP_EXTFRAME }, // 12V Battery current POLL_LIST_END }; \ No newline at end of file