From 6877d46549cfc603eb057d0cc82c106d6fd03cb5 Mon Sep 17 00:00:00 2001 From: Carsten Schmiemann Date: Sat, 16 Apr 2022 21:32:07 +0200 Subject: [PATCH] Fix LBC temperatures --- .../vehicle_renaultzoe_ph2/src/LBC_pids.cpp | 63 +++++++++---------- .../vehicle_renaultzoe_ph2/src/ph2_poller.h | 4 +- 2 files changed, 32 insertions(+), 35 deletions(-) diff --git a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/LBC_pids.cpp b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/LBC_pids.cpp index 77799c5..5cc0515 100644 --- a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/LBC_pids.cpp +++ b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/LBC_pids.cpp @@ -34,13 +34,12 @@ void OvmsVehicleRenaultZoePh2::IncomingLBC(uint16_t type, uint16_t pid, const ch } case 0x925D: { //Battery current StandardMetrics.ms_v_bat_current->SetValue((float) (CAN_UINT(0) * 0.03125 - 1020), Amps); - ESP_LOGD(TAG, "925D LBC ms_v_bat_current: %d", CAN_UINT(0)); ESP_LOGD(TAG, "925D LBC ms_v_bat_current: %f", (CAN_UINT(0) * 0.03125 - 1020)); break; } case 0x9012: { //Battery average temperature - StandardMetrics.ms_v_bat_temp->SetValue((float) (CAN_UINT(0) * 0.625 - 40), Celcius); - ESP_LOGD(TAG, "9012 LBC ms_v_bat_temp: %f", (CAN_UINT(0) * 0.625 - 40)); + StandardMetrics.ms_v_bat_temp->SetValue((float) (CAN_UINT(0) * 0.0625 - 40), Celcius); + ESP_LOGD(TAG, "9012 LBC ms_v_bat_temp: %f", (CAN_UINT(0) * 0.0625 - 40)); break; } case 0x9002: { //Battery SOC @@ -79,15 +78,13 @@ void OvmsVehicleRenaultZoePh2::IncomingLBC(uint16_t type, uint16_t pid, const ch break; } case 0x9014: { //Cell Max Temp - StandardMetrics.ms_v_bat_pack_tmax->SetValue((float) (CAN_UINT(0) * 0.625 - 40), Celcius); - ESP_LOGD(TAG, "9014 LBC ms_v_bat_pack_tmax RAW: %d", CAN_UINT(0)); - ESP_LOGD(TAG, "9014 LBC ms_v_bat_pack_tmax: %f", CAN_UINT(0) * 0.625 - 40); + StandardMetrics.ms_v_bat_pack_tmax->SetValue((float) (CAN_UINT(0) * 0.0625 - 40), Celcius); + ESP_LOGD(TAG, "9014 LBC ms_v_bat_pack_tmax: %f", CAN_UINT(0) * 0.0625 - 40); break; } case 0x9013: { //Cell Min Temp - StandardMetrics.ms_v_bat_pack_tmin->SetValue((float) (CAN_UINT(0) * 0.625 - 40), Celcius); - ESP_LOGD(TAG, "9013 LBC ms_v_bat_pack_tmin RAW: %d", CAN_UINT(0)); - ESP_LOGD(TAG, "9013 LBC ms_v_bat_pack_tmin: %f", CAN_UINT(0) * 0.625 - 40); + StandardMetrics.ms_v_bat_pack_tmin->SetValue((float) (CAN_UINT(0) * 0.0625 - 40), Celcius); + ESP_LOGD(TAG, "9013 LBC ms_v_bat_pack_tmin: %f", CAN_UINT(0) * 0.0625 - 40); break; } case 0x9018: { //Max charge power @@ -101,63 +98,63 @@ void OvmsVehicleRenaultZoePh2::IncomingLBC(uint16_t type, uint16_t pid, const ch break; } case 0x9131: { - BmsSetCellTemperature(1, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(1, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x9132: { - BmsSetCellTemperature(2, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(2, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x9133: { - BmsSetCellTemperature(3, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(3, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x9134: { - BmsSetCellTemperature(4, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(4, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x9135: { - BmsSetCellTemperature(5, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(5, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x9136: { - BmsSetCellTemperature(6, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(6, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x9137: { - BmsSetCellTemperature(7, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(7, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x9138: { - BmsSetCellTemperature(8, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(8, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x9139: { - BmsSetCellTemperature(9, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(9, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x913A: { - BmsSetCellTemperature(10, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(10, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x913B: { - BmsSetCellTemperature(11, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(11, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x913C: { - BmsSetCellTemperature(12, CAN_UINT(0) * 0.625 - 40); - ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.625 - 40); + BmsSetCellTemperature(12, CAN_UINT(0) * 0.0625 - 40); + ESP_LOGD(TAG, "%x: %f C", pid, CAN_UINT(0) * 0.0625 - 40); break; } case 0x9021: { diff --git a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/ph2_poller.h b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/ph2_poller.h index c806a1a..a811c6c 100644 --- a/OVMS.V3/components/vehicle_renaultzoe_ph2/src/ph2_poller.h +++ b/OVMS.V3/components/vehicle_renaultzoe_ph2/src/ph2_poller.h @@ -56,7 +56,7 @@ static const OvmsVehicle::poll_pid_t renault_zoe_polls[] = { { 0x18dadaf1, 0x18daf1da, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x2191, { 0, 10, 10, 10 }, 0, ISOTP_EXTFRAME }, // Power usage by ptc //BCM -//{ 0x1861, 0x1893, VEHICLE_POLL_TYPE_OBDIISESSION, SESSION_DEFAULT, { 60, 60, 60, 60 }, 0, ISOTP_EXTFRAME }, // OBD Extended Diagnostic Session +{ 0x1861, 0x1893, VEHICLE_POLL_TYPE_OBDIISESSION, SESSION_DEFAULT, { 60, 60, 60, 60 }, 0, ISOTP_EXTFRAME }, // OBD Extended Diagnostic Session { 0x1861, 0x1893, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x4204, { 0, 300, 300, 300 }, 0, ISOTP_EXTADR }, // TPMS pressure - front left { 0x1861, 0x1893, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x4205, { 0, 300, 300, 300 }, 0, ISOTP_EXTADR }, // TPMS pressure - front right { 0x1861, 0x1893, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x4206, { 0, 300, 300, 300 }, 0, ISOTP_EXTADR }, // TPMS pressure - rear left @@ -201,7 +201,7 @@ static const OvmsVehicle::poll_pid_t renault_zoe_polls[] = { { 0x1860, 0x1892, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x43D8, { 0, 3, 10, 10 }, 0, ISOTP_EXTADR }, // Compressor speed //UCM -//{ 0x1869, 0x1901, VEHICLE_POLL_TYPE_OBDIISESSION, SESSION_EXTDIAG, { 60, 60, 60, 60 }, 0, ISOTP_EXTADR }, // OBD Extended Diagnostic Session +{ 0x1869, 0x1901, VEHICLE_POLL_TYPE_OBDIISESSION, SESSION_EXTDIAG, { 0, 60, 60, 60 }, 0, ISOTP_EXTADR }, // OBD Extended Diagnostic Session { 0x1869, 0x1901, VEHICLE_POLL_TYPE_OBDIIEXTENDED, 0x6079, { 0, 10, 5, 3 }, 0, ISOTP_EXTFRAME }, // 12V Battery current POLL_LIST_END }; \ No newline at end of file