From 4c8c88af2224580c9e0228760f6bc2af502d076a Mon Sep 17 00:00:00 2001 From: Angus Gratton Date: Tue, 4 Dec 2018 11:02:49 +1100 Subject: [PATCH] windows_install_prerequisites: Fix bug if IDF_PATH is not set if IDF_PATH is empty, [ -n ] test passes needs to be [ -n "" ] Closes https://github.com/espressif/esp-idf/issues/2769 TW27714 --- tools/windows/windows_install_prerequisites.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/windows/windows_install_prerequisites.sh b/tools/windows/windows_install_prerequisites.sh index 6a2366316..f75f54eec 100644 --- a/tools/windows/windows_install_prerequisites.sh +++ b/tools/windows/windows_install_prerequisites.sh @@ -37,8 +37,8 @@ pacman --noconfirm -S --needed gettext-devel gcc git make ncurses-devel flex bis mingw-w64-i686-python2-pip mingw-w64-i686-python2-cryptography unzip winpty # if IDF_PATH is set, install requirements now as well -if [ -n $IDF_PATH ]; then - python -m pip install -r $IDF_PATH/requirements.txt +if [ -n "$IDF_PATH" ]; then + python -m pip install -r "$IDF_PATH/requirements.txt" fi # Automatically download precompiled toolchain, unpack at /opt/xtensa-esp32-elf/