From c2053a8e65dd42c6212ee7fe5dd81fc581061746 Mon Sep 17 00:00:00 2001 From: David Cermak Date: Thu, 30 Apr 2020 14:13:51 +0200 Subject: [PATCH] esp_netif: fix default connect handler to check dhcpc return value Closes https://github.com/espressif/esp-idf/issues/5184 --- components/esp_netif/esp_netif_handlers.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/components/esp_netif/esp_netif_handlers.c b/components/esp_netif/esp_netif_handlers.c index c57266576..e308d00c5 100644 --- a/components/esp_netif/esp_netif_handlers.c +++ b/components/esp_netif/esp_netif_handlers.c @@ -47,7 +47,12 @@ void esp_netif_action_connected(void *esp_netif, esp_event_base_t base, int32_t ESP_LOGD(TAG, "esp_netif action connected with netif%p from event_id=%d", esp_netif, event_id); esp_netif_up(esp_netif); - esp_netif_dhcpc_get_status(esp_netif, &status); + if (!(esp_netif_get_flags(esp_netif) & ESP_NETIF_DHCP_CLIENT)) { + // No more actions for interfaces without DHCP client flag + return; + } + + ESP_NETIF_CALL_CHECK("connected action: dhcpc failed", esp_netif_dhcpc_get_status(esp_netif, &status), ESP_OK); if (status == ESP_NETIF_DHCP_INIT) { esp_netif_dhcpc_start(esp_netif); } else if (status == ESP_NETIF_DHCP_STOPPED) {