Crash_Override/OVMS3-idf
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

wpa_supplicant: Fix some memleaks and invalid memory access

Browse source 
Add changes to fix issues reported in clang analyzer
This commit is contained in:
kapil.gupta 2020-05-14 10:50:20 +05:30
parent 44d1c90d25
commit b91bba1a07
2 changed files with 21 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
components/wpa_supplicant/src/wps/wps.c
View file

@ -273,42 +273,40 @@ _out:
* provisioning, -1 if wps_a is considered more like, or 0 if no preference
*/
int wps_ap_priority_compar(const struct wpabuf *wps_a,
const struct wpabuf *wps_b)
const struct wpabuf *wps_b)
{
struct wps_parse_attr *attr_a, *attr_b;
struct wps_parse_attr *attr = NULL;
int sel_a, sel_b;
int ret = 0;
int ret = 0; /* No preference */
attr_a = (struct wps_parse_attr *)os_zalloc(sizeof(struct wps_parse_attr));
attr_b = (struct wps_parse_attr *)os_zalloc(sizeof(struct wps_parse_attr));
attr = os_zalloc(sizeof(*attr));
if (attr_a == NULL || attr_b == NULL) {
ret = 0;
goto _out;
if (!attr)
return ret;
if (wps_a == NULL || wps_parse_msg(wps_a, attr) < 0) {
ret = 1;
goto exit;
}
sel_a = attr->selected_registrar && *(attr->selected_registrar) != 0;
if (wps_a == NULL || wps_parse_msg(wps_a, attr_a) < 0)
return 1;
if (wps_b == NULL || wps_parse_msg(wps_b, attr_b) < 0)
return -1;
sel_a = attr_a->selected_registrar && *attr_a->selected_registrar != 0;
sel_b = attr_b->selected_registrar && *attr_b->selected_registrar != 0;
if (wps_b == NULL || wps_parse_msg(wps_b, attr) < 0) {
ret = -1;
goto exit;
}
sel_b = attr->selected_registrar && *(attr->selected_registrar) != 0;
if (sel_a && !sel_b) {
ret = -1;
goto _out;
goto exit;
}
if (!sel_a && sel_b) {
ret = 1;
goto _out;
goto exit;
}
_out:
if (attr_a)
os_free(attr_a);
if (attr_b)
os_free(attr_b);
exit:
os_free(attr);
return ret;
}

1
components/wpa_supplicant/src/wps/wps_registrar.c
View file

@ -1689,6 +1689,7 @@ int wps_build_cred(struct wps_data *wps, struct wpabuf *msg)
if (random_get_bytes(r, sizeof(r)) < 0)
return -1;
os_free(wps->new_psk);
wps->new_psk = NULL;
//wps->new_psk = base64_encode(r, sizeof(r), &wps->new_psk_len);
if (wps->new_psk == NULL)
return -1;