From 9afe47425beee9c35788ee343612ba70c6edb6d1 Mon Sep 17 00:00:00 2001 From: "V.Dudnik" Date: Sun, 5 May 2019 19:12:33 +0300 Subject: [PATCH 1/2] project_config_mk: fix if condition --- make/project_config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/make/project_config.mk b/make/project_config.mk index 79a6efd01..0046c44fb 100644 --- a/make/project_config.mk +++ b/make/project_config.mk @@ -4,7 +4,7 @@ COMPONENT_KCONFIGS := $(foreach component,$(COMPONENT_PATHS),$(wildcard $(component)/Kconfig)) COMPONENT_KCONFIGS_PROJBUILD := $(foreach component,$(COMPONENT_PATHS),$(wildcard $(component)/Kconfig.projbuild)) -ifdef MSYSTEM +ifeq ($(OS),Windows_NT) # kconfiglib requires Windows-style paths for kconfig files COMPONENT_KCONFIGS := $(shell cygpath -w $(COMPONENT_KCONFIGS)) COMPONENT_KCONFIGS_PROJBUILD := $(shell cygpath -w $(COMPONENT_KCONFIGS_PROJBUILD)) From 0ef3af367d24cda46cf4c9ec3904a3689352d117 Mon Sep 17 00:00:00 2001 From: Renz Christian Bagaporo Date: Mon, 6 May 2019 20:28:32 +0800 Subject: [PATCH 2/2] ldgen,make: simplify os check --- make/ldgen.mk | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/make/ldgen.mk b/make/ldgen.mk index 705edcb56..ebc7449c8 100644 --- a/make/ldgen.mk +++ b/make/ldgen.mk @@ -3,17 +3,9 @@ LDGEN_SECTIONS_INFO_FILES = $(foreach lib, $(COMPONENT_LIBRARIES), $(BUILD_DIR_BASE)/$(lib)/lib$(lib).a.sections_info) LDGEN_FRAGMENT_FILES = $(COMPONENT_LDFRAGMENTS) -ON_WINDOWS:=n - -ifdef OS - ifeq ($(OS),Windows_NT) - ON_WINDOWS:=y - endif -endif - # Target to generate linker script generator from fragments presented by each of # the components -ifeq ($(ON_WINDOWS),y) +ifeq ($(OS),Windows_NT) define ldgen_process_template $(BUILD_DIR_BASE)/ldgen.section_infos: $(LDGEN_SECTIONS_INFO_FILES) $(IDF_PATH)/make/ldgen.mk printf "$(foreach info,$(LDGEN_SECTIONS_INFO_FILES),$(subst \,/,$(shell cygpath -w $(info)))\n)" > $(BUILD_DIR_BASE)/ldgen.section_infos @@ -31,7 +23,7 @@ $(2): $(1) $(LDGEN_FRAGMENT_FILES) $(SDKCONFIG) $(BUILD_DIR_BASE)/ldgen.section_ --env "COMPONENT_KCONFIGS_PROJBUILD=$(foreach k, $(COMPONENT_KCONFIGS_PROJBUILD), $(shell cygpath -w $(k)))" \ --env "IDF_CMAKE=n" endef -else # ON_WINDOWS +else # Windows_NT define ldgen_process_template $(BUILD_DIR_BASE)/ldgen.section_infos: $(LDGEN_SECTIONS_INFO_FILES) $(IDF_PATH)/make/ldgen.mk printf "$(foreach info,$(LDGEN_SECTIONS_INFO_FILES),$(info)\n)" > $(BUILD_DIR_BASE)/ldgen.section_infos @@ -49,7 +41,7 @@ $(2): $(1) $(LDGEN_FRAGMENT_FILES) $(SDKCONFIG) $(BUILD_DIR_BASE)/ldgen.section_ --env "COMPONENT_KCONFIGS_PROJBUILD=$(COMPONENT_KCONFIGS_PROJBUILD)" \ --env "IDF_CMAKE=n" endef -endif # ON_WINDOWS +endif # Windows_NT define ldgen_create_commands $(foreach lib, $(COMPONENT_LIBRARIES), \