Crash_Override/OVMS3-idf
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

ble_mesh: Check if assigned node address is duplicated

Browse source 
Previously only check the node address when it is assigned by the
application layer. Here we also check the address when the address
is allocated internally. And this will be useful when some mesh
internal tests are performed.
This commit is contained in:
lly 2020-03-27 20:22:38 +08:00 committed by bot
parent 80feb4e70a
commit 77cf16e337
1 changed files with 22 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
components/bt/esp_ble_mesh/mesh_core/provisioner_prov.c
View file

@ -626,7 +626,7 @@ static int provisioner_check_unprov_dev_info(const u8_t uuid[16], bt_mesh_prov_b
/* Check if the device has already been provisioned */ /* Check if the device has already been provisioned */
if (bt_mesh_provisioner_find_node_with_uuid(uuid, false)) { if (bt_mesh_provisioner_find_node_with_uuid(uuid, false)) {
BT_WARN("Provisioned before, start to provision again"); BT_INFO("Provisioned before, start to provision again");
return 0; return 0;
} }
@ -2492,38 +2492,35 @@ static void send_prov_data(const u8_t idx)
sys_put_be16(prev_addr, &pdu[23]); sys_put_be16(prev_addr, &pdu[23]);
link[idx].unicast_addr = prev_addr; link[idx].unicast_addr = prev_addr;
} else { } else {
u16_t alloc_addr = BLE_MESH_ADDR_UNASSIGNED;
if (BLE_MESH_ADDR_IS_UNICAST(link[idx].assign_addr)) { if (BLE_MESH_ADDR_IS_UNICAST(link[idx].assign_addr)) {
if (link[idx].assign_addr + link[idx].element_num - 1 > max_addr) { alloc_addr = link[idx].assign_addr;
BT_ERR("%s, Too large assigned address for the device", __func__);
goto fail;
}
/* Make sure the assigned unicast address is not identical with any unicast address
* of other nodes. Also need to make sure the address is not identical with any
* address of Provisioner.
*/
if (bt_mesh_provisioner_check_is_addr_dup(link[idx].assign_addr, link[idx].element_num, true)) {
BT_ERR("%s, Assigned address 0x%04x is duplicated", __func__, link[idx].assign_addr);
goto fail;
}
sys_put_be16(link[idx].assign_addr, &pdu[23]);
link[idx].unicast_addr = link[idx].assign_addr;
} else { } else {
/* If this device to be provisioned is a new device */ /* If this device to be provisioned is a new device */
if (prov_ctx.curr_alloc_addr == BLE_MESH_ADDR_UNASSIGNED) { if (prov_ctx.curr_alloc_addr == BLE_MESH_ADDR_UNASSIGNED) {
BT_ERR("%s, No unicast address can be allocated", __func__); BT_ERR("%s, No unicast address can be allocated", __func__);
goto fail; goto fail;
} }
alloc_addr = prov_ctx.curr_alloc_addr;
}
if (prov_ctx.curr_alloc_addr + link[idx].element_num - 1 > max_addr) { if (alloc_addr + link[idx].element_num - 1 > max_addr) {
BT_ERR("%s, Not enough unicast address for the device", __func__); BT_ERR("%s, Not enough unicast address for the device", __func__);
goto fail; goto fail;
} }
sys_put_be16(prov_ctx.curr_alloc_addr, &pdu[23]); /* Make sure the assigned unicast address is not identical with any unicast
link[idx].unicast_addr = prov_ctx.curr_alloc_addr; * address of other nodes. And make sure the address is not identical with
* any unicast address of Provisioner.
*/
if (bt_mesh_provisioner_check_is_addr_dup(alloc_addr, link[idx].element_num, true)) {
BT_ERR("%s, Assigned address 0x%04x is duplicated", __func__, alloc_addr);
goto fail;
} }
sys_put_be16(alloc_addr, &pdu[23]);
link[idx].unicast_addr = alloc_addr;
} }
prov_buf_init(&buf, PROV_DATA); prov_buf_init(&buf, PROV_DATA);