From 4f622270302d7fc0419852dafaef14f260250839 Mon Sep 17 00:00:00 2001 From: Angus Gratton Date: Wed, 20 Mar 2019 10:42:29 +1100 Subject: [PATCH] cmake: Set COMPONENT_PATH during early expansion of dependencies Works around bug where components/soc/CMakeLists.txt was testing "EXISTS ${COMPONENT_PATH}/${SOC_NAME}" and this test could pass during early expansion if COMPONENT_PATH was empty and a directory /esp32 exists on Windows. Closes https://github.com/espressif/esp-idf/issues/3195 --- tools/cmake/scripts/expand_requirements.cmake | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/cmake/scripts/expand_requirements.cmake b/tools/cmake/scripts/expand_requirements.cmake index 56d78fd3b..8197016ff 100644 --- a/tools/cmake/scripts/expand_requirements.cmake +++ b/tools/cmake/scripts/expand_requirements.cmake @@ -161,9 +161,9 @@ function(expand_component_requirements component) endif() set_property(GLOBAL APPEND PROPERTY SEEN_COMPONENTS ${component}) - find_component_path("${component}" "${ALL_COMPONENTS}" "${ALL_COMPONENT_PATHS}" component_path) - debug("Expanding dependencies of ${component} @ ${component_path}") - if(NOT component_path) + find_component_path("${component}" "${ALL_COMPONENTS}" "${ALL_COMPONENT_PATHS}" COMPONENT_PATH) + debug("Expanding dependencies of ${component} @ ${COMPONENT_PATH}") + if(NOT COMPONENT_PATH) set_property(GLOBAL APPEND PROPERTY COMPONENTS_NOT_FOUND ${component}) return() endif() @@ -173,7 +173,7 @@ function(expand_component_requirements component) unset(COMPONENT_REQUIRES) unset(COMPONENT_PRIV_REQUIRES) set(COMPONENT ${component}) - include(${component_path}/CMakeLists.txt) + include(${COMPONENT_PATH}/CMakeLists.txt) get_property(requires GLOBAL PROPERTY "${component}_REQUIRES") get_property(requires_priv GLOBAL PROPERTY "${component}_PRIV_REQUIRES") @@ -193,7 +193,7 @@ function(expand_component_requirements component) endif() # Now append this component to the full list (after its dependencies) - set_property(GLOBAL APPEND PROPERTY BUILD_COMPONENT_PATHS ${component_path}) + set_property(GLOBAL APPEND PROPERTY BUILD_COMPONENT_PATHS ${COMPONENT_PATH}) set_property(GLOBAL APPEND PROPERTY BUILD_COMPONENTS ${component}) endfunction()