From 496bfe38420940cc8c6a0e6380b77dbd1490afee Mon Sep 17 00:00:00 2001 From: Pieter du Preez Date: Mon, 24 Dec 2018 11:37:09 +0000 Subject: [PATCH] Initialized some uninitialized variables in rtc_clk.c and ringbuf.c. The following 2 compiler warnings are only reproducible when setting: OPTIMIZATION_FLAGS = -Ofast esp-idf/components/soc/esp32/rtc_clk.c: In function 'rtc_clk_cpu_freq_get': esp-idf/components/soc/esp32/rtc_clk.c:506:12: error: 'freq' may be used uninitialized in this function [-Werror=maybe-uninitialized] return freq; esp-idf/components/esp_ringbuf/ringbuf.c: In function 'xRingbufferReceiveSplitFromISR': esp-idf/components/esp_ringbuf/ringbuf.c:934:26: error: 'pvTempTailItem' may be used uninitialized in this function [-Werror=maybe-uninitialized] *ppvTailItem = pvTempTailItem; Closes https://github.com/espressif/esp-idf/pull/2878 --- components/esp_ringbuf/ringbuf.c | 2 +- components/soc/esp32/rtc_clk.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/components/esp_ringbuf/ringbuf.c b/components/esp_ringbuf/ringbuf.c index 9a7117b74..558b61c6d 100644 --- a/components/esp_ringbuf/ringbuf.c +++ b/components/esp_ringbuf/ringbuf.c @@ -920,7 +920,7 @@ BaseType_t xRingbufferReceiveSplitFromISR(RingbufHandle_t xRingbuffer, void **pp configASSERT(ppvHeadItem != NULL && ppvTailItem != NULL); //Attempt to retrieve multiple items - void *pvTempHeadItem, *pvTempTailItem; + void *pvTempHeadItem = NULL, *pvTempTailItem = NULL; size_t xTempHeadSize, xTempTailSize; if (prvReceiveGenericFromISR(pxRingbuffer, &pvTempHeadItem, &pvTempTailItem, &xTempHeadSize, &xTempTailSize, 0) == pdTRUE) { //At least one item was received diff --git a/components/soc/esp32/rtc_clk.c b/components/soc/esp32/rtc_clk.c index 0afde2cff..4a917c8bb 100644 --- a/components/soc/esp32/rtc_clk.c +++ b/components/soc/esp32/rtc_clk.c @@ -500,7 +500,7 @@ rtc_cpu_freq_t rtc_clk_cpu_freq_get() { rtc_cpu_freq_config_t config; rtc_clk_cpu_freq_get_config(&config); - rtc_cpu_freq_t freq; + rtc_cpu_freq_t freq = RTC_CPU_FREQ_XTAL; rtc_clk_cpu_freq_from_mhz_internal(config.freq_mhz, &freq); return freq; }