From 3b3050b09f2c7cd9b6c77b0e2698fb712970970a Mon Sep 17 00:00:00 2001 From: Roland Dobai Date: Mon, 27 Apr 2020 16:15:52 +0200 Subject: [PATCH] tools: Make Unicode from subprocess result in the CMake convert script Fixes an issue with Python 3 in MSYS where it fails while trying to join paths where one part is Unicode (default string on Python3) and the second part are bytes (returned by the subprocess call). Closes https://github.com/espressif/esp-idf/issues/5189 --- tools/cmake/convert_to_cmake.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/cmake/convert_to_cmake.py b/tools/cmake/convert_to_cmake.py index 588b9bdd5..4e3b0a4b6 100755 --- a/tools/cmake/convert_to_cmake.py +++ b/tools/cmake/convert_to_cmake.py @@ -122,7 +122,7 @@ def convert_project(project_path): for p in component_paths: if "MSYSTEM" in os.environ: cmd = ["cygpath", "-w", p] - p = subprocess.check_output(cmd).strip() + p = subprocess.check_output(cmd).decode('utf-8').strip() converted_components += convert_component(project_path, p)