Crash_Override/OVMS3-idf
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

examples: Fixing possible memory leak, not freeing "run_time" prior to returning

Browse source 
Merges https://github.com/espressif/esp-idf/pull/2367
This commit is contained in:
mharizanov 2018-09-04 15:52:11 +03:00 committed by Mahavir Jain
parent c15e7b18f8
commit 17177e352b
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
examples/storage/nvs_rw_blob/main/nvs_blob_example_main.c
View file

@ -80,7 +80,10 @@ esp_err_t save_run_time(void)
uint32_t* run_time = malloc(required_size + sizeof(uint32_t));
if (required_size > 0) {
err = nvs_get_blob(my_handle, "run_time", run_time, &required_size);
if (err != ESP_OK) return err;
if (err != ESP_OK) {
free(run_time);
return err;
}
}
// Write value including previously saved blob if available
@ -131,7 +134,10 @@ esp_err_t print_what_saved(void)
} else {
uint32_t* run_time = malloc(required_size);
err = nvs_get_blob(my_handle, "run_time", run_time, &required_size);
if (err != ESP_OK) return err;
if (err != ESP_OK) {
free(run_time);
return err;
}
for (int i = 0; i < required_size / sizeof(uint32_t); i++) {
printf("%d: %d\n", i + 1, run_time[i]);
}