Crash_Override/OVMS3-idf
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Merge branch 'bugfix/freemodbus_fix_memcmp_coveriity_id291158' into 'master'

Browse source 
freemodbus: bug fix memcmp result truncated to 1 byte (coveriity id291158)

Closes IDF-1836

See merge request espressif/esp-idf!9239
This commit is contained in:
Ivan Grokhotkov 2020-06-23 01:42:59 +08:00
commit 158ae5cbb1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
components/freemodbus/serial_master/modbus_controller/mbc_serial_master.c
View file

@ -361,7 +361,7 @@ static esp_err_t mbc_serial_master_set_request(char* name, mb_param_mode_t mode,
continue; // The length of strings is different then check next record in the table
}
// Compare the name of parameter with parameter key from table
uint8_t comp_result = memcmp((const char*)name, (const char*)reg_ptr->param_key, (size_t)param_key_len);
int comp_result = memcmp((const void*)name, (const void*)reg_ptr->param_key, (size_t)param_key_len);
if (comp_result == 0) {
// The correct line is found in the table and reg_ptr points to the found parameter description
request->slave_addr = reg_ptr->mb_slave_addr;