Merge branch 'bugfix/ci_static_analysis_fail_on_new_issue' into 'master'

ci: update static analysis rules to fail on any new issue

Closes IDF-686 and IDF-973

See merge request espressif/esp-idf!6424

components/console/argtable3/argtable3.c

@@ -3007,7 +3007,7 @@ static int trex_newnode(TRex *exp, TRexNodeType type)
 		exp->_nallocated *= 2;
 		exp->_nodes = (TRexNode *)realloc(exp->_nodes, exp->_nallocated * sizeof(TRexNode));
 	}
-	exp->_nodes[exp->_nsize++] = n;
+	exp->_nodes[exp->_nsize++] = n; // NOLINT(clang-analyzer-unix.Malloc)
 	newid = exp->_nsize - 1;
 	return (int)newid;
 }

components/esp_system/panic.c

@@ -338,6 +338,6 @@ void __attribute__((noreturn)) panic_abort(const char *details)
 #endif
 #endif
 
-    *((int *) 0) = 0; // should be an invalid operation on targets
+    *((int *) 0) = 0; // NOLINT(clang-analyzer-core.NullDereference) should be an invalid operation on targets
     while(1);
 }

components/freertos/tasks.c

@@ -649,7 +649,7 @@ void taskYIELD_OTHER_CORE( BaseType_t xCoreID, UBaseType_t uxPriority )
 	BaseType_t i;
 
 	if (xCoreID != tskNO_AFFINITY) {
-		if ( curTCB->uxPriority < uxPriority ) {
+		if ( curTCB->uxPriority < uxPriority ) {	// NOLINT(clang-analyzer-core.NullDereference) IDF-685
 			vPortYieldOtherCore( xCoreID );
 		}
 	}

components/lwip/apps/dhcpserver/dhcpserver.c

@@ -253,11 +253,13 @@ void node_remove_from_list(list_node **phead, list_node *pdelete)
         *phead = NULL;
     } else {
         if (plist == pdelete) {
-            *phead = plist->pnext;
+            // Note: Ignoring the "use after free" warnings, as it could only happen
+            // if the linked list contains loops
+            *phead = plist->pnext; // NOLINT(clang-analyzer-unix.Malloc)
             pdelete->pnext = NULL;
         } else {
             while (plist != NULL) {
-                if (plist->pnext == pdelete) {
+                if (plist->pnext == pdelete) { // NOLINT(clang-analyzer-unix.Malloc)
                     plist->pnext = pdelete->pnext;
                     pdelete->pnext = NULL;
                 }
@@ -1216,6 +1218,7 @@ static void kill_oldest_dhcps_pool(void)
     list_node *minpre = NULL, *minp = NULL;
     struct dhcps_pool *pdhcps_pool = NULL, *pmin_pool = NULL;
     pre = plist;
+    assert(pre != NULL && pre->pnext != NULL); // Expect the list to have at least 2 nodes
     p = pre->pnext;
     minpre = pre;
     minp = p;

components/sdmmc/sdmmc_io.c

@@ -567,6 +567,9 @@ esp_err_t sdmmc_io_get_cis_data(sdmmc_card_t* card, uint8_t* out_buffer, size_t
     esp_err_t ret = ESP_OK;
     WORD_ALIGNED_ATTR uint8_t buf[CIS_GET_MINIMAL_SIZE];
 
+    /* Pointer to size is a mandatory parameter */
+    assert(inout_cis_size);
+
     /*
      * CIS region exist in 0x1000~0x17FFF of FUNC 0, get the start address of it
      * from CCCR register.
@@ -585,7 +588,7 @@ esp_err_t sdmmc_io_get_cis_data(sdmmc_card_t* card, uint8_t* out_buffer, size_t
      * existing.
      */
     size_t max_reading = UINT32_MAX;
-    if (inout_cis_size && *inout_cis_size != 0) {
+    if (*inout_cis_size != 0) {
         max_reading = *inout_cis_size;
     }
 

components/wpa_supplicant/src/ap/wpa_auth.c

@@ -2036,7 +2036,7 @@ SM_STATE(WPA_PTK_GROUP, REKEYNEGOTIATING)
                (!sm->Pair ? WPA_KEY_INFO_INSTALL : 0),
                rsc, gsm->GNonce, kde, pos - kde, gsm->GN, 1);
     if (sm->wpa == WPA_VERSION_WPA2)
-        os_free(kde);
+        os_free(kde);  // NOLINT(clang-analyzer-unix.Malloc)
 }
 
 

components/wpa_supplicant/src/esp_supplicant/esp_wpa2.c

@@ -752,7 +752,7 @@ static int eap_peer_sm_init(void)
 
     s_wpa2_data_lock = xSemaphoreCreateRecursiveMutex();
     if (!s_wpa2_data_lock) {
-        wpa_printf(MSG_ERROR, "wpa2 eap_peer_sm_init: failed to alloc data lock");
+        wpa_printf(MSG_ERROR, "wpa2 eap_peer_sm_init: failed to alloc data lock");  // NOLINT(clang-analyzer-unix.Malloc)
         return ESP_ERR_NO_MEM;
     }
 

components/wpa_supplicant/src/wps/wps.c

@@ -275,7 +275,7 @@ int wps_ap_priority_compar(const struct wpabuf *wps_a,
     }
 
     if (wps_a == NULL || wps_parse_msg(wps_a, attr_a) < 0)
-        return 1;
+        return 1;   // NOLINT(clang-analyzer-unix.Malloc)
     if (wps_b == NULL || wps_parse_msg(wps_b, attr_b) < 0)
         return -1;
 

components/wpa_supplicant/src/wps/wps_registrar.c

@@ -1644,11 +1644,11 @@ int wps_build_cred(struct wps_data *wps, struct wpabuf *msg)
 			return -1;
 		wps->new_psk_len--; /* remove newline */
 		while (wps->new_psk_len &&
-		       wps->new_psk[wps->new_psk_len - 1] == '=')
+		       wps->new_psk[wps->new_psk_len - 1] == '=')	// NOLINT(clang-analyzer-unix.Malloc)
 			wps->new_psk_len--;
 		wpa_hexdump_ascii_key(MSG_DEBUG, "WPS: Generated passphrase",
 				      wps->new_psk, wps->new_psk_len);
-		os_memcpy(wps->cred.key, wps->new_psk, wps->new_psk_len);
+		os_memcpy(wps->cred.key, wps->new_psk, wps->new_psk_len);	// NOLINT(clang-analyzer-unix.Malloc)
 		wps->cred.key_len = wps->new_psk_len;
 	} else if (wps->use_psk_key && wps->wps->psk_set) {
 		char hex[65];

tools/ci/static-analysis-rules.yml

@@ -1,6 +1,6 @@
 limits:
-  "clang-analyzer-core.NullDereference" : 9
-  "clang-analyzer-unix.Malloc" : 9
+  "clang-analyzer-core.NullDereference" : 0
+  "clang-analyzer-unix.Malloc" : 0
 
 ignore:
   - "llvm-header-guard"
@@ -12,7 +12,7 @@ skip:
   - "components/asio/asio"
   - "components/bootloader/subproject/components/micro-ecc/micro-ecc"
   - "components/bt/lib"
-  - "components/coap/libcoap"
+  - "components/coap"
   - "components/esp_wifi/lib_esp32"
   - "components/expat/expat"
   - "components/json/cJSON"