Add RemoteCommand 'status' command.

As DMRGateway, it reports connection status.

Command sent: "status" to port: 7642
dstar:n/a dmr:conn ysf:n/a p25:n/a nxdn:n/a fm:n/a

RemoveCommand has been slighlty modified, as using Log on a read-only filesystem simply forbids the strings to be displayed.
Another solution would be to set LogInitialisse's filePath to "/tmp/" for *nix systems.
This commit is contained in:
Daniel Caujolle-Bert 2021-03-22 20:27:08 +01:00
parent 0088b0b225
commit 27b7d3fc41
No known key found for this signature in database
GPG Key ID: 51AED7171EC00614
21 changed files with 90 additions and 9 deletions

View File

@ -316,6 +316,11 @@ bool CDMRDirectNetwork::writeTalkerAlias(unsigned int id, unsigned char type, co
return write(buffer, 15U);
}
bool CDMRDirectNetwork::isConnected() const
{
return (m_status == RUNNING);
}
void CDMRDirectNetwork::close()
{
LogMessage("Closing DMR Network");

View File

@ -55,6 +55,8 @@ public:
virtual void clock(unsigned int ms);
virtual bool isConnected() const;
virtual void close();
private:

View File

@ -287,6 +287,11 @@ bool CDMRGatewayNetwork::writeTalkerAlias(unsigned int id, unsigned char type, c
return write(buffer, 15U);
}
bool CDMRGatewayNetwork::isConnected() const
{
return (m_enabled && (m_addrLen != 0));
}
void CDMRGatewayNetwork::close()
{
LogMessage("DMR, Closing DMR Network");

View File

@ -56,6 +56,8 @@ public:
virtual void clock(unsigned int ms);
virtual bool isConnected() const;
virtual void close();
private:

View File

@ -48,6 +48,8 @@ public:
virtual void clock(unsigned int ms) = 0;
virtual bool isConnected() const = 0;
virtual void close() = 0;
private:

View File

@ -314,6 +314,11 @@ void CDStarNetwork::reset()
m_inId = 0U;
}
bool CDStarNetwork::isConnected() const
{
return (m_enabled && (m_addrLen != 0));
}
void CDStarNetwork::close()
{
m_socket.close();

View File

@ -46,6 +46,8 @@ public:
void reset();
bool isConnected() const;
void close();
void clock(unsigned int ms);

View File

@ -635,7 +635,7 @@ int CMMDVMHost::run()
LogInfo(" Address: %s", address.c_str());
LogInfo(" Port: %u", port);
m_remoteControl = new CRemoteControl(address, port);
m_remoteControl = new CRemoteControl(this, address, port);
ret = m_remoteControl->open();
if (!ret) {
@ -2140,3 +2140,14 @@ void CMMDVMHost::processEnableCommand(bool& mode, bool enabled)
if (!m_modem->writeConfig())
LogError("Cannot write Config to MMDVM");
}
void CMMDVMHost::buildNetworkStatusString(std::string &str)
{
str = "";
str += std::string("dstar:") + (((m_dstarNetwork == NULL) || (m_dstarEnabled == false)) ? "n/a" : (m_dstarNetwork->isConnected() ? "conn" : "disc"));
str += std::string(" dmr:") + (((m_dmrNetwork == NULL) || (m_dmrEnabled == false)) ? "n/a" : (m_dmrNetwork->isConnected() ? "conn" : "disc"));
str += std::string(" ysf:") + (((m_ysfNetwork == NULL) || (m_ysfEnabled == false)) ? "n/a" : (m_ysfNetwork->isConnected() ? "conn" : "disc"));
str += std::string(" p25:") + (((m_p25Network == NULL) || (m_p25Enabled == false)) ? "n/a" : (m_p25Network->isConnected() ? "conn" : "disc"));
str += std::string(" nxdn:") + (((m_nxdnNetwork == NULL) || (m_nxdnEnabled == false)) ? "n/a" : (m_nxdnNetwork->isConnected() ? "conn" : "disc"));
str += std::string(" fm:") + (m_fmEnabled ? "conn" : "n/a");
}

View File

@ -51,6 +51,8 @@ public:
int run();
void buildNetworkStatusString(std::string &str);
private:
CConf m_conf;
CModem* m_modem;

View File

@ -153,6 +153,11 @@ void CNXDNIcomNetwork::reset()
{
}
bool CNXDNIcomNetwork::isConnected() const
{
return (m_enabled && (m_addrLen != 0));
}
void CNXDNIcomNetwork::close()
{
m_socket.close();

View File

@ -43,6 +43,8 @@ public:
virtual void reset();
virtual bool isConnected() const;
virtual void close();
virtual void clock(unsigned int ms);

View File

@ -835,6 +835,11 @@ void CNXDNKenwoodNetwork::reset()
m_seen4 = false;
}
bool CNXDNKenwoodNetwork::isConnected() const
{
return (m_enabled && (m_rtcpAddrLen != 0U) && (m_rtpAddrLen != 0U));
}
void CNXDNKenwoodNetwork::close()
{
m_rtcpSocket.close();

View File

@ -42,6 +42,8 @@ public:
virtual void reset();
virtual bool isConnected() const;
virtual void close();
virtual void clock(unsigned int ms);

View File

@ -46,6 +46,8 @@ public:
virtual void reset() = 0;
virtual bool isConnected() const = 0;
virtual void close() = 0;
virtual void clock(unsigned int ms) = 0;

View File

@ -424,6 +424,11 @@ unsigned int CP25Network::read(unsigned char* data, unsigned int length)
return c;
}
bool CP25Network::isConnected() const
{
return (m_enabled && (m_addrLen != 0));
}
void CP25Network::close()
{
m_socket.close();

View File

@ -43,6 +43,8 @@ public:
unsigned int read(unsigned char* data, unsigned int length);
bool isConnected() const;
void close();
void clock(unsigned int ms);

View File

@ -75,7 +75,7 @@ int CRemoteCommand::send(const std::string& command)
int retStatus = 0;
if (CUDPSocket::lookup("127.0.0.1", m_port, addr, addrLen) != 0) {
LogError("Unable to resolve the address of the host");
::fprintf(stderr, "Unable to resolve the address of the host\n");
return 1;
}
@ -91,14 +91,14 @@ int CRemoteCommand::send(const std::string& command)
return 1;
}
LogMessage("Command sent: \"%s\" to port: %u", command.c_str(), m_port);
::fprintf(stdout, "Command sent: \"%s\" to port: %u\n", command.c_str(), m_port);
std::this_thread::sleep_for(std::chrono::milliseconds(50));
int len = socket.read((unsigned char*)&buffer[0], BUFFER_LENGTH, addr, addrLen);
int len = socket.read((unsigned char*)buffer, BUFFER_LENGTH, addr, addrLen);
if (len > 0) {
buffer[len] = '\0';
LogMessage("%s", buffer);
::fprintf(stdout, "%s\n", buffer);
}
else
{

View File

@ -17,6 +17,7 @@
*/
#include "RemoteControl.h"
#include "MMDVMHost.h"
#include "Log.h"
#include <cstdio>
@ -32,7 +33,8 @@ const unsigned int CW_ARGS = 2U;
const unsigned int BUFFER_LENGTH = 100U;
CRemoteControl::CRemoteControl(const std::string address, unsigned int port) :
CRemoteControl::CRemoteControl(CMMDVMHost *host, const std::string address, unsigned int port) :
m_host(host),
m_socket(address, port),
m_command(RCD_NONE),
m_args()
@ -131,7 +133,16 @@ REMOTE_COMMAND CRemoteControl::getCommand()
} else if (m_args.at(0U) == "reload") {
// Reload command is in the form of "reload"
m_command = RCD_RELOAD;
}
} else if (m_args.at(0U) == "status") {
if (m_host != NULL) {
m_host->buildNetworkStatusString(replyStr);
}
else {
replyStr = "KO";
}
m_command = RCD_CONNECTION_STATUS;
}
else
replyStr = "KO";

View File

@ -24,6 +24,8 @@
#include <vector>
#include <string>
class CMMDVMHost;
enum REMOTE_COMMAND {
RCD_NONE,
RCD_MODE_IDLE,
@ -48,12 +50,13 @@ enum REMOTE_COMMAND {
RCD_DISABLE_FM,
RCD_PAGE,
RCD_CW,
RCD_RELOAD
RCD_RELOAD,
RCD_CONNECTION_STATUS
};
class CRemoteControl {
public:
CRemoteControl(const std::string address, unsigned int port);
CRemoteControl(class CMMDVMHost *host, const std::string address, unsigned int port);
~CRemoteControl();
bool open();
@ -69,6 +72,7 @@ public:
void close();
private:
CMMDVMHost* m_host;
CUDPSocket m_socket;
REMOTE_COMMAND m_command;
std::vector<std::string> m_args;

View File

@ -183,6 +183,11 @@ void CYSFNetwork::reset()
::memset(m_tag, ' ', YSF_CALLSIGN_LENGTH);
}
bool CYSFNetwork::isConnected() const
{
return (m_enabled && (m_addrLen != 0));
}
void CYSFNetwork::close()
{
m_socket.close();

View File

@ -42,6 +42,8 @@ public:
void reset();
bool isConnected() const;
void close();
void clock(unsigned int ms);