From a07d6bde3fe0d8181cdd64c0c9eed270c5face13 Mon Sep 17 00:00:00 2001 From: Paul Kronenwetter Date: Fri, 24 Jun 2022 16:17:44 -0400 Subject: [PATCH] Heeding some advice from codefactor review. --- create_node_env.sh | 2 +- create_python_env.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/create_node_env.sh b/create_node_env.sh index 0df2c890..42afec15 100755 --- a/create_node_env.sh +++ b/create_node_env.sh @@ -18,7 +18,7 @@ PATH_ADDITIONS="`pwd`/node_modules/bin:`pwd`/node_modules/.bin" # Verify NPM exists. -if [ -z "${NPM}" -o ! -x "${NPM}" ]; then +if [ -z "${NPM}" ] || [ ! -x "${NPM}" ]; then echo "Error: ${NPM} isn't executable or doesn't exist." exit 1 fi diff --git a/create_python_env.sh b/create_python_env.sh index dca3732c..d35c58d6 100755 --- a/create_python_env.sh +++ b/create_python_env.sh @@ -33,7 +33,7 @@ fi ${CHOSEN} -m venv "${VENVDIR}" # Activate the virtual environment, if needed -if [ -z "${VIRTUAL_ENV}" -o "${VIRTUAL_ENV}" != "${VENVDIR}" ]; then +if [ -z "${VIRTUAL_ENV}" ] || [ "${VIRTUAL_ENV}" != "${VENVDIR}" ]; then source "${VENVDIR}/activate" fi