From 4d40b593033c5cc52d02cc55929d56cd976f0479 Mon Sep 17 00:00:00 2001
From: DJ2LS <dj2ls@proton.me>
Date: Mon, 23 Oct 2023 20:55:22 +0200
Subject: [PATCH 1/2] fix error where stopping the modem wasnt possible

---
 gui/src/js/sock.js | 7 ++++++-
 modem/sock.py      | 4 ++--
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/gui/src/js/sock.js b/gui/src/js/sock.js
index 8ca2d0c7..26f78b95 100644
--- a/gui/src/js/sock.js
+++ b/gui/src/js/sock.js
@@ -46,7 +46,7 @@ function connectModem() {
 
 client.on("connect", function () {
   console.log("Modem connection established");
-
+  stateStore.modem_running_state = "running"
   stateStore.busy_state = "-";
   stateStore.arq_state = "-";
   stateStore.frequency = "-";
@@ -63,7 +63,11 @@ client.on("error", function (err) {
     console.log("Modem connection error");
     console.log(err);
     modemShowConnectStateError = 0;
+    stateStore.modem_running_state = "stopped"
   }
+
+
+
   setTimeout(connectModem, 500);
   client.destroy();
   stateStore.busy_state = "-";
@@ -93,6 +97,7 @@ client.on("end", function (data) {
   stateStore.dbfs_level = 0;
   stateStore.updateTncState(client.readyState);
   client.destroy();
+  stateStore.modem_running_state = "stopped"
 
   setTimeout(connectModem, 500);
 });
diff --git a/modem/sock.py b/modem/sock.py
index a1da13c7..097faa87 100644
--- a/modem/sock.py
+++ b/modem/sock.py
@@ -1128,12 +1128,12 @@ class ThreadedTCPRequestHandler(socketserver.StreamRequestHandler):
 
     def daemon_stop_modem(self, received_json):
         try:
+            log.warning("[SCK] Stopping Modem")
+            Daemon.modemstarted = False
             Daemon.modemprocess.kill()
             # unregister process from atexit to avoid process zombies
             atexit.unregister(Daemon.modemprocess.kill)
 
-            log.warning("[SCK] Stopping Modem")
-            Daemon.modemstarted = False
             command_response("stop_modem", True)
         except Exception as err:
             command_response("stop_modem", False)

From ba95ef2d64f6850d5acefe274b809a354a25db97 Mon Sep 17 00:00:00 2001
From: codefactor-io <support@codefactor.io>
Date: Mon, 23 Oct 2023 18:56:11 +0000
Subject: [PATCH 2/2] [CodeFactor] Apply fixes to commit 4d40b59

---
 gui/src/js/sock.js | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/gui/src/js/sock.js b/gui/src/js/sock.js
index 26f78b95..dca93f07 100644
--- a/gui/src/js/sock.js
+++ b/gui/src/js/sock.js
@@ -46,7 +46,7 @@ function connectModem() {
 
 client.on("connect", function () {
   console.log("Modem connection established");
-  stateStore.modem_running_state = "running"
+  stateStore.modem_running_state = "running";
   stateStore.busy_state = "-";
   stateStore.arq_state = "-";
   stateStore.frequency = "-";
@@ -63,11 +63,9 @@ client.on("error", function (err) {
     console.log("Modem connection error");
     console.log(err);
     modemShowConnectStateError = 0;
-    stateStore.modem_running_state = "stopped"
+    stateStore.modem_running_state = "stopped";
   }
 
-
-
   setTimeout(connectModem, 500);
   client.destroy();
   stateStore.busy_state = "-";
@@ -97,7 +95,7 @@ client.on("end", function (data) {
   stateStore.dbfs_level = 0;
   stateStore.updateTncState(client.readyState);
   client.destroy();
-  stateStore.modem_running_state = "stopped"
+  stateStore.modem_running_state = "stopped";
 
   setTimeout(connectModem, 500);
 });